Bug 157930 - [patch] net/tightvnc: respect LOCALBASE|CFLAGS|STRIP
Summary: [patch] net/tightvnc: respect LOCALBASE|CFLAGS|STRIP
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 22:10 UTC by Pan Tsu
Modified: 2011-08-04 11:30 UTC (History)
0 users

See Also:

Attachments
a.diff (3.43 KB, patch)
2011-06-16 22:10 UTC, Pan Tsu 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pan Tsu 2011-06-16 22:10:09 UTC 
- fix build on non-default LOCALBASE
- use global CFLAGS picking up any += modifications from make.conf
- strip binaries based on STRIP either explicitly or as part of
  WITH_DEBUG|DEBUG_FLAGS
- silence warning about ServerExtraDefines redefinition on amd64
- regen newline in vnclibs.def patch (fixes editing in emacs)

How-To-Repeat: $ export LOCALBASE=/foo DEBUG_FLAGS=-ggdb
$ make install WITH_DEBUG=
[...]
cc -c -O2 -pipe -ansi -pedantic -Dasm=__asm  -I. -I../../../.././/exports/include/X11 -I../../../.././/include/fonts -I../../../.././/exports/include/X11          -I../../cfb -I../../mfb -I../../mi -I../../include -I../../os           -I../../../.././/../include -I/usr/local/include -L/usr/local/lib  -I../../../.././ -I../../../.././/exports/include  -DCSRG_BASED -DSHAPE                                                                                                                                       -DGCCUSESGAS -DSTATIC_COLOR -DAVOID_GLYPHBLT -DPIXPRIV   -D_XSERVER64 -DNDEBUG   -DFUNCPROTO=15 -DNARROWPROTO  -DDDXOSINIT -DSERVER_LOCK -DDDXOSFATALERROR -DDDXTIME  cursor.c
rm -f libvnc.a
ar clq libvnc.a init.o sockets.o kbdptr.o cmap.o draw.o cutpaste.o        dispcur.o sprite.o rfbserver.o translate.o httpd.o auth.o        rre.o corre.o stats.o hextile.o zlib.o tight.o cursor.o
ranlib libvnc.a
make: don't know how to make /usr/local/lib/libjpeg.a. Stop
*** Error code 2
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-16 22:10:50 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-08-04 11:22:21 UTC 
itetcu      2011-08-04 10:22:12 UTC

  FreeBSD ports repository

  Modified files:
    net/tightvnc         Makefile 
    net/tightvnc/files   patch-Xvnc::config::cf::FreeBSD.cf 
                         patch-Xvnc::config::cf::vnclibs.def 
  Log:
  - fix build on non-default LOCALBASE
  - use global CFLAGS picking up any += modifications from make.conf / etc.
  - strip binaries based on STRIP either explicitly or as part of
    WITH_DEBUG|DEBUG_FLAGS
  - silence warning about ServerExtraDefines redefinition on amd64
  - regen newline in vnclibs.def patch (fixes editing in emacs)
  - pet portlint
  
  PR:             157930
  Submitted by:   Pan Tsu <inyaoo@gmail.com>
  
  Revision  Changes    Path
  1.41      +4 -1      ports/net/tightvnc/Makefile
  1.5       +13 -3     ports/net/tightvnc/files/patch-Xvnc::config::cf::FreeBSD.cf
  1.5       +5 -4      ports/net/tightvnc/files/patch-Xvnc::config::cf::vnclibs.def
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2011-08-04 11:23:03 UTC 
State Changed
From-To: open->closed

Committed. Thanks!