Bug 158191 - [patch] audio/mpg123: disable vendor cflags
Summary: [patch] audio/mpg123: disable vendor cflags
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 03:10 UTC by Pan Tsu
Modified: 2011-06-23 10:04 UTC (History)
0 users

See Also:


Attachments
a.diff (648 bytes, patch)
2011-06-23 03:10 UTC, Pan Tsu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pan Tsu 2011-06-23 03:10:09 UTC
Vendor uses -funroll-all-loops that generates slower code which is
documented in gcc(1) manpage. If user cares about small optimization
(unlike asm) then he'd probably benefit more from plain `-O3' on gcc46.

How-To-Repeat: # user time from decoding an album's mp3 directory
$ ministat -n *
x base gcc, default cflags
+ base gcc, default cflags + --with-optimization=0
* gcc46 + my cflags
% gcc46 + my cflags + --with-optimization=0
# gcc46 + my cflags + generic_fpu
@ gcc46 + my cflags + generic_fpu + --with-optimization=0
    N           Min           Max        Median           Avg        Stddev
x  10          9.39          9.62           9.5         9.493   0.078464429
+  10           9.3          9.54          9.43         9.436   0.083426614
*  10           8.7          8.92          8.78         8.781   0.071250731
%  10           8.3          8.54           8.5         8.459   0.076514341
#  10         12.97         13.23         13.12        13.104   0.094068533
@  10         12.73         12.93         12.83        12.832   0.059029183

and numeric data generated by

#! /bin/sh

times=10
dir='/path/to/album'

while [ $((i+=1)) -le $times ]; do
    find "$dir" -iname \*mp3 -exec time -p mpg123 -tq {} + 2>&1
done | while read desc time; do
    case $desc in
	user) echo $time
    esac
done
Comment 1 Edwin Groothuis freebsd_committer 2011-06-23 03:10:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->novel

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2011-06-23 09:56:08 UTC
novel       2011-06-23 08:55:58 UTC

  FreeBSD ports repository

  Modified files:
    audio/mpg123         Makefile 
  Log:
  Disable vendor optimization flags in CFLAGS.
  
  PR:             158191
  Submitted by:   Pan Tsu <inyaoo@gmail.com>
  
  Revision  Changes    Path
  1.83      +2 -1      ports/audio/mpg123/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Roman Bogorodskiy freebsd_committer 2011-06-23 10:04:49 UTC
State Changed
From-To: open->closed

Committed, thanks!