Bug 158557 - [patch] /etc/rc.d/pf broken messages
Summary: [patch] /etc/rc.d/pf broken messages
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 8.2-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 10:10 UTC by David Demelier
Modified: 2018-10-19 21:20 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Demelier 2011-07-01 10:10:02 UTC
The current /etc/rc.d/pf service prints status messages like:

Enabling pfpf enabled
Comment 1 Mark Linimon 2011-07-01 23:21:16 UTC
----- Forwarded message from David Demelier <demelier.david@gmail.com> -----

--- pf.diff begins here ---
--- /etc/rc.d/pf.orig	2011-07-01 10:33:45.000000000 +0200
+++ /etc/rc.d/pf	2011-07-01 10:57:10.000000000 +0200
@@ -29,17 +29,19 @@
 	$pf_program -F all > /dev/null 2>&1
 	$pf_program -f "$pf_rules" $pf_flags
 	if ! $pf_program -s info | grep -q "Enabled" ; then
-		$pf_program -e
+		msg=`$pf_program -e 2>&1`
+		check_startmsgs && echo -n ": ${msg}" || echo -n "${msg}"
+
 	fi
-	check_startmsgs && echo '.'
+	echo '.'
 }

 pf_stop()
 {
 	if $pf_program -s info | grep -q "Enabled" ; then
-		echo -n 'Disabling pf'
-		$pf_program -d
-		echo '.'
+		echo -n 'Disabling pf: '
+		msg=`$pf_program -d 2>&1`
+		echo "$msg."
 	fi
 }

--- pf.diff ends here ---

-- 
David Demelier

----- End forwarded message -----
Comment 2 Gavin Atkinson freebsd_committer freebsd_triage 2011-07-02 23:12:22 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-rc

Over to maintainer(s)
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:50 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 4 Kristof Provost freebsd_committer freebsd_triage 2018-10-19 21:20:41 UTC
This is no longer a problem in 12 (and presumably earlier as well).