Bug 158630 - sysutils/smartmontools daily script improvement
sysutils/smartmontools daily script improvement
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Romain Tartière
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-04 08:50 UTC by Romain Tartière
Modified: 2011-07-04 10:10 UTC (History)
0 users

See Also:


Attachments
smart.diff (358 bytes, patch)
2011-07-04 08:50 UTC, Romain Tartière
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Tartière freebsd_committer 2011-07-04 08:50:04 UTC
smartmontool port can install a daily script for checking disks.  When a
disk is failing, a full report is included in the generated mail, otherwise a
'OK' message is output instead.

When a disk has been failing in the past but the situation is back to
normal, the script still outputs a verbose report, requiring more attention to
see that it is not a new problem.

Fix: smartctl sets bit 5 (counting from 0) of the return value to 1 for such cases.

---------------------------------------8<-------------------------------------
       Bit 5: SMART status check returned "DISK OK" but  we  found  that  some
              (usage  or  prefail)  Attributes  have been <= threshold at some
              time in the past.
---------------------------------------8<-------------------------------------

This can be used to produce clever output:
How-To-Repeat: 
Enable smart status in /etc/periodic.conf:

  daily_status_smart_enable="YES"
  daily_status_smart_devices="ad4 ad6 ad10 ad12"

ad4 has failed in the past because of a cooling problem.  The daily mail
include:

---------------------------------------8<-------------------------------------
Checking health of /dev/ad4: === START OF INFORMATION SECTION ===
Model Family:     Seagate Barracuda 7200.10
Device Model:     ST3320620AS
[...12 lines...]
=== START OF READ SMART DATA SECTION ===
SMART overall-health self-assessment test result: PASSED
See vendor-specific Attribute list for marginal Attributes.
[...41 lines...]
189 High_Fly_Writes         0x003a   100   100   000    Old_age   Always       -       0
190 Airflow_Temperature_Cel 0x0022   057   044   045    Old_age   Always   In_the_past 43 (Min/Max 36/50)
194 Temperature_Celsius     0x0022   043   056   000    Old_age   Always       -       43 (0 22 0 0)
[...23 lines...]
Checking health of /dev/ad6: OK
Checking health of /dev/ad10: OK
Checking health of /dev/ad12: OK
---------------------------------------8<-------------------------------------
Comment 1 Edwin Groothuis freebsd_committer 2011-07-04 08:50:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->romain

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2011-07-04 08:50:16 UTC
Maintainer of sysutils/smartmontools,

Please note that PR ports/158630 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158630

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2011-07-04 08:50:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 samm 2011-07-04 09:50:38 UTC
Looks fine, thank you.
Please commit.
Comment 5 dfilter freebsd_committer 2011-07-04 10:09:53 UTC
romain      2011-07-04 09:09:39 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/smartmontools Makefile 
    sysutils/smartmontools/files smart.in 
  Log:
  Improve periodic script to display a short report when a disk attribute failed
  in the past but is now back to normal.
  
  PR:             ports/158630
  Submitted by:   romain
  Approved by:    Alex Samorukov <samm@os2.kiev.ua> (maintainer)
  
  Revision  Changes    Path
  1.51      +1 -0      ports/sysutils/smartmontools/Makefile
  1.10      +3 -1      ports/sysutils/smartmontools/files/smart.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Romain Tartière freebsd_committer 2011-07-04 10:10:14 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!