Problem 1: python2.6 is hardcoded for the Makefile test target
Problem 2: During the documentation build, sed throws many errors.
The attached patch fixes both of these issues
Fix: Patch attached with submission follows:
How-To-Repeat: > make test
This installs aws first, and the sed errors will scroll by.
If python2.7 installed, the test will file.
Maintainer of www/aws,
Please note that PR ports/158896 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
Edwin Groothuis via the GNATS Auto Assign Tool
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
The person that submitted the PR is also the maintainer.
The first word of the PR's title is "[MAINTAINER]".
Therefore, I approve the patch!
On 7/14/2011 3:10 PM, Edwin Groothuis wrote:
> Maintainer of www/aws,
> Please note that PR ports/158896 has just been submitted.
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> The full text of the PR can be found at:
I see why this happened now.
I left the class as sw-bug instead of changing it to maintainer-update.
Since the maintainer submitted the patch, please change the class to
Sorry about that,
I'll take it.
actually a maintainer update.
I have applied your patch but when trying to build the port in my tinderbox
I still get some errors during the documentation generation phase:
Did I miss something?
Moreover, do you really believe the PORTREVISION bump is needed here?
I agree that a PORTREVISION bump is unnecessary.
The errors shown on the log turn out to be limited to FreeBSD 7.x, which
I didn't test. I have already supplied replacement patches directly to
Frederic which fix this and allow www/aws to build on all supported
culot 2011-07-19 10:58:23 UTC
FreeBSD ports repository
www/aws Makefile pkg-plist
- Do not hardcode Python version in Makefile test target
- Avoid sed errors during documentation build
Submitted by: John Marino <firstname.lastname@example.org> (maintainer)
Revision Changes Path
1.2 +1 -1 ports/www/aws/Makefile
1.1 +27 -0 ports/www/aws/files/patch-docs__gentexifile (new)
1.1 +30 -0 ports/www/aws/files/patch-templates_parser__docs__gentexifile (new)
1.2 +3 -0 ports/www/aws/pkg-plist
email@example.com mailing list
To unsubscribe, send any mail to "firstname.lastname@example.org"