Currently, DESKTOP_ENTRIES creates a filename for the .desktop file from the Exec field. The problem with this approach is that you can't specify arguments to the command, otherwise you will get strangely name .desktop files.
Fix: Create a new DESKTOP_ENTRIES variable that has a field for the filename. The attached patch adds a new DESKTOP_ENTRIESv2 variable that handles this.
Patch attached with submission follows:
How-To-Repeat: install any one of these 3 ports that use arguments in their Exec field:
In principle this looks good, but can you provide patches to a couple of ports
that would convert them to the new variable? Just to see it in action.. Thank
Just noticed that I had forgotten a '; \' after the check to make sure
that the filename is defined in check-desktop-entries for
The attached patch fixes this.
On Fri, Jul 15, 2011 at 3:16 AM, <firstname.lastname@example.org> wrote:
> Synopsis: Mk/bsd.ports.mk: Add a filename field to DESKTOP_ENTRIES
> State-Changed-From-To: open->feedback
> State-Changed-By: pav
> State-Changed-When: Fri Jul 15 08:15:04 UTC 2011
> In principle this looks good, but can you provide patches to a couple of ports
> that would convert them to the new variable? Just to see it in action.. Thank
The attached patch is for the games/tome, misc/metalink-editor and
On Fri, Jul 15, 2011 at 11:41 AM, Scot Hetzel <email@example.com> wrote:
> Just noticed that I had forgotten a '; \' after the check to make sure
> that the filename is defined in check-desktop-entries for
> The attached patch fixes this.
ignore the previous patch to fix the missing '; \', instead use this one.
Not sure why my replies are not showing up properly in the PR.
When applying the patch use patch.txt and the last bsd.port.mk-diff2 patch.
The DESKTOP_ENTRIESv2-ports-diff is a patch for the games/tome,
misc/metalink-editor and www/links to show that the DESKTOP_ENTRIESv2
8 years without anyone really having a look at it :(
I will close this bug for now, in the hope it is no really needed anymore. Please reopen it, if I am wrong.