Bug 160507 - [PATCH] bsd.gcc.mk: prefer the default version of gcc to the minimum acceptable version in USE_GCC
Summary: [PATCH] bsd.gcc.mk: prefer the default version of gcc to the minimum acceptab...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 10:00 UTC by Brendan Fabeny
Modified: 2011-10-31 11:21 UTC (History)
0 users

See Also:


Attachments
file.diff (1.07 KB, patch)
2011-09-06 10:00 UTC, Brendan Fabeny
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Fabeny freebsd_committer freebsd_triage 2011-09-06 10:00:02 UTC
Change the USE_GCC construct so that if an acceptable version of gcc is not already installed on a machine when beginning the build of a port that requires one, then the new port build will favor the default version of gcc used by USE_FORTRAN=yes over the minimum acceptable version of gcc specified in the port's USE_GCC variable.

This will save a lot of time in tinderboxes, and will mean that more default packages are compiled with a newer and better version of gcc, and that users of default packages will have to download and install multiple versions of gcc less often than they do now.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-06 10:00:51 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gerald

bsd.gcc.mk is gerald territory (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-10-30 01:34:53 UTC
gerald      2011-10-30 01:34:39 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.gcc.mk 
  Log:
  When USE_GCC=X.Y+ has been specified, prefer the default version of
  GCC (the one which also USE_FORTRAN=yes chooses) in case we do have
  to install GCC in any case.  Only if an acceptable version of GCC
  is already present use that one.
  
  This will ease the load on tinderboxes, further the use of current
  versions of GCC, and minimize the need to download/carry several
  versions of GCC for users of pre-built packages.
  
  PR:             160507
  Submitted by:   bf
  
  Revision  Changes    Path
  1.59      +10 -5     ports/Mk/bsd.gcc.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Gerald Pfeifer freebsd_committer freebsd_triage 2011-10-31 11:20:31 UTC
State Changed
From-To: open->closed

(A variation) of the patch has been committed yesterday.  Thanks for 
that and the good discussions around improving things!