Bug 160528 - [patch] shells/mksh: update /etc/shells on deinstall
Summary: [patch] shells/mksh: update /etc/shells on deinstall
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 21:50 UTC by Kaspars Bankovskis
Modified: 2011-11-25 18:20 UTC (History)
0 users

See Also:


Attachments
file.diff (871 bytes, patch)
2011-09-06 21:50 UTC, Kaspars Bankovskis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kaspars Bankovskis 2011-09-06 21:50:09 UTC
- added pkg-plist, with similar instructions as other shells have

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-06 21:50:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2011-11-24 16:36:19 UTC
State Changed
From-To: open->closed

that port provide all that. no changes needed.
Comment 3 Kaspars Bankovskis 2011-11-24 19:38:35 UTC
No, it doesn't provide that.

$ grep mksh /etc/shells
$ sudo make install clean
..
$ grep mksh /etc/shells
/usr/local/bin/mksh
$ sudo make deinstall
===>  Deinstalling for shells/mksh
===>   Deinstalling mksh-r40.c
$ which mksh
$ grep mksh /etc/shells
/usr/local/bin/mksh        <- still present

/etc/shells is updated on post-install, but not on deinstall.
it doesn't matter if you install it once and for all, but for the
sake of correctness it should clean after itself.

compare with other shell ports, shells/pdksh for example.

On Thu, Nov 24, 2011 at 04:36:20PM +0000, miwi@FreeBSD.org wrote:
> Synopsis: [patch] shells/mksh: update /etc/shells on deinstall
> 
> State-Changed-From-To: open->closed
> State-Changed-By: miwi
> State-Changed-When: Thu Nov 24 16:36:19 UTC 2011
> State-Changed-Why: 
> that port provide all that. no changes needed.
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=160528
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2011-11-25 00:30:43 UTC
State Changed
From-To: closed->open

reopen, submitter pointing a valid point
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2011-11-25 18:18:01 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-11-25 18:18:04 UTC
miwi        2011-11-25 18:17:51 UTC

  FreeBSD ports repository

  Modified files:
    shells/mksh          Makefile 
  Added files:
    shells/mksh          pkg-plist 
  Log:
  - Make sure after deinstall /etc/shells is clean
  - Bump PORTREVISION
  
  PR:             160528
  Submitted by:   Kaspars Bankovskis <kaspars@bankovskis.lv>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.31      +1 -2      ports/shells/mksh/Makefile
  1.1       +5 -0      ports/shells/mksh/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"