Bug 160677 - dns/noip has garbled interface list
Summary: dns/noip has garbled interface list
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-12 14:30 UTC by Stanislaw Halik
Modified: 2011-09-12 15:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.93 KB, patch)
2011-09-12 14:30 UTC, Stanislaw Halik
no flags Details | Diff
noip.diff.txt (1.86 KB, text/plain)
2011-09-12 14:44 UTC, Stanislaw Halik
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislaw Halik 2011-09-12 14:30:13 UTC
The dns/noip ports needs to have -Dbsd_with_getifaddrs passed during the compilation stage. The current port attempts to account for it by setting CFLAGS, yet it is unsupported by the port's Makefile.

The following is a patch (actually identical to ports/155974 in functionality) for this. The interface list is no longer garbled which randomly prevented the user from selecting some of the interfaces from the list.

Also, as per ehaupt@'s suggestion, I'm stepping up with a request for maintainership of the port, as he no longer uses it.

Fix: Diff attached.

Patch attached with submission follows:
How-To-Repeat: Compile, then run noip2 as "noip2 -C /tmp/foo". The initial interface list will contain non-ASCII characters as well as empty fields. Sometimes an desired interface will be 'clean' despite that, sometimes not.
Comment 1 Edwin Groothuis freebsd_committer 2011-09-12 14:30:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Stanislaw Halik 2011-09-12 14:44:04 UTC
My apologies. The original diff doesn't apply since some of the tabs got 
changed to spaces. A corrected version follows.
Comment 3 dfilter service freebsd_committer 2011-09-12 15:01:51 UTC
ehaupt      2011-09-12 14:01:42 UTC

  FreeBSD ports repository

  Modified files:
    dns/noip             Makefile 
    dns/noip/files       patch-Makefile patch-noip2.c 
  Log:
  Fix network interface detection. Pass maintainership to submitter.
  
  PR:             160677
  Submitted by:   sthalik@tehran.lain.pl
  
  Revision  Changes    Path
  1.22      +4 -6      ports/dns/noip/Makefile
  1.8       +5 -15     ports/dns/noip/files/patch-Makefile
  1.8       +2 -2      ports/dns/noip/files/patch-noip2.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Emanuel Haupt freebsd_committer 2011-09-12 15:01:57 UTC
State Changed
From-To: open->closed

Committed, thanks!