Bug 161561 - [patch] games/el: actually respect CC
Summary: [patch] games/el: actually respect CC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 23:30 UTC by Nali Toja
Modified: 2011-10-20 18:50 UTC (History)
0 users

See Also:


Attachments
cc.diff (1.66 KB, patch)
2011-10-13 23:30 UTC, Nali Toja
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nali Toja 2011-10-13 23:30:07 UTC
CC/CXX/LINK are unconditionally defined in WRKSRC/make.conf that is
included in Makefile.linux. And there is no need to define CC/CXX
as they're part of default_variables[] in gmake(1)

  $ printf 'all:\n\tCC=$(CC)\n\tCXX=$(CXX)\n' | env -i gmake -f -
  CC=cc
  CXX=g++

How-To-Repeat: http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.9-exp.20110723205754/el-180_6.log

remove `@' from commands to see that build invokes `gcc'
Comment 1 Edwin Groothuis freebsd_committer 2011-10-13 23:30:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->acm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2011-10-20 18:48:10 UTC
acm         2011-10-20 17:47:59 UTC

  FreeBSD ports repository

  Modified files:
    games/el             Makefile distinfo 
    games/el-data        Makefile distinfo 
  Added files:
    games/el/files       patch-Makefile.bsd patch-make.defaults 
  Removed files:
    games/el/files       patch-Makefile.linux 
  Log:
  - Update to 1.9.2
  - Add ELSOUND and ELMUSIC options. It installs additional sound and music files
  - Remove Makefile.linux patch file
  - Re-add Makefile.bsd patch file
  - Respect CC/CXX/LINK [1]
  - Few others modifications
  
  PR:     161561
  Submitted by:   Nali Toja <nalitoja __ at __ gmail.com> [1]
  
  Revision  Changes    Path
  1.8       +33 -10    ports/games/el-data/Makefile
  1.8       +6 -2      ports/games/el-data/distinfo
  1.29      +6 -7      ports/games/el/Makefile
  1.10      +2 -2      ports/games/el/distinfo
  1.5       +49 -0     ports/games/el/files/patch-Makefile.bsd (new)
  1.3       +0 -48     ports/games/el/files/patch-Makefile.linux (dead)
  1.1       +19 -0     ports/games/el/files/patch-make.defaults (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jose Alonso Cardenas Marquez freebsd_committer 2011-10-20 18:50:12 UTC
State Changed
From-To: open->closed

- Committed with few modifications. Thanks!!