Bug 161564 - [patch] lang/python27: prune __wchar_t define from CFLAGS
Summary: [patch] lang/python27: prune __wchar_t define from CFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 01:30 UTC by Nali Toja
Modified: 2011-11-05 13:20 UTC (History)
0 users

See Also:


Attachments
clang.diff (534 bytes, patch)
2011-10-14 01:30 UTC, Nali Toja
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nali Toja 2011-10-14 01:30:03 UTC
Many ports py- ports fail to build with clang because python-config
has -D__wchar_t=wchar_t in CFLAGS that's also defined in <sys/_types.h>.

Added by perky@ in lang/python24 (2.4.2) to workaround curses.h configure
check, the fix was merged into 2.4 branch several months later (before 2.4.3).

  http://bugs.python.org/issue1244610

How-To-Repeat: http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.9-exp.20110723205754/py27-pcapy-0.10.5.log

$ cd net/py-pcapy; make
===>  Vulnerability check disabled, database not found
===>  License check disabled, port has not defined LICENSE
===>  Extracting for py27-pcapy-0.10.5
=> SHA256 Checksum OK for pcapy-0.10.5.tar.gz.
===>  Patching for py27-pcapy-0.10.5
===>  Applying FreeBSD patches for py27-pcapy-0.10.5
===>   py27-pcapy-0.10.5 depends on file: /usr/local/bin/python2.7 - found
===>  Configuring for py27-pcapy-0.10.5
running config
===>  Building for py27-pcapy-0.10.5
running build
running build_ext
building 'pcapy' extension
creating build
creating build/temp.freebsd-9.9-BLAH-amd64-2.7
clang -DNDEBUG -O2 -pipe -D__wchar_t=wchar_t -O2 -pipe -fPIC -I/usr/local/include/python2.7 -c pcapdumper.cc -o build/temp.freebsd-9.9-BLAH-amd64-2.7/pcapdumper.o
In file included from pcapdumper.cc:11:
In file included from /usr/local/include/python2.7/Python.h:33:
In file included from /usr/include/stdio.h:41:
/usr/include/sys/_types.h:90:21: error: cannot combine with previous 'type-name' declaration specifier
typedef __ct_rune_t     __wchar_t;      /* wchar_t (see above) */
                        ^
<command line>:2:19: note: expanded from:
#define __wchar_t wchar_t
                  ^
1 error generated.
error: command 'clang' failed with exit status 1
*** Error code 1
Comment 1 Edwin Groothuis freebsd_committer 2011-10-14 01:30:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Nali Toja 2011-10-14 01:35:24 UTC
Nali Toja <nalitoja@gmail.com> writes:

[...]
> Added by perky@ in lang/python24 (2.4.2) to workaround curses.h configure
> check, the fix was merged into 2.4 branch several months later (before 2.4.3).
>
>   http://bugs.python.org/issue1244610

After a bit more googling I think it's this one

  http://www.mail-archive.com/python-list@python.org/msg65065.html
Comment 3 dfilter service freebsd_committer 2011-11-05 13:18:39 UTC
sunpoet     2011-11-05 13:18:26 UTC

  FreeBSD ports repository

  Modified files:
    lang/python24        Makefile 
    lang/python25        Makefile 
    lang/python26        Makefile 
    lang/python27        Makefile 
    lang/python31        Makefile 
    lang/python32        Makefile 
  Log:
  - Remove outdated patch to prune __wchar_t from CFLAGS (python-config --cflags)
  - Bump PORTREVISION for package change
  
  PR:             ports/161564
  Submitted by:   Nali Toja <nalitoja@gmail.com>
  
  Revision  Changes    Path
  1.176     +1 -4      ports/lang/python24/Makefile
  1.167     +2 -4      ports/lang/python25/Makefile
  1.178     +2 -4      ports/lang/python26/Makefile
  1.182     +2 -4      ports/lang/python27/Makefile
  1.176     +2 -4      ports/lang/python31/Makefile
  1.181     +2 -4      ports/lang/python32/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Po-Chuan Hsieh freebsd_committer 2011-11-05 13:18:41 UTC
State Changed
From-To: open->closed

Committed. Thanks! 


Comment 5 Po-Chuan Hsieh freebsd_committer 2011-11-05 13:18:41 UTC
Responsible Changed
From-To: freebsd-python->sunpoet

Committed. Thanks!