Bug 161591 - [patch] audio/xmms2: workaround deadlock in waf (showing up on pointyhat too)
Summary: [patch] audio/xmms2: workaround deadlock in waf (showing up on pointyhat too)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 18:20 UTC by Guido Falsi
Modified: 2011-10-23 17:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.06 KB, patch)
2011-10-14 18:20 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2011-10-14 18:20:07 UTC
This port was disabled on pointyhat due to runaway processes. I
tracked this down to a deadlock condition in some python multithreaded
code.

I "fixed" this by adding a small sleep (0.02 seconds, should not
slow down the build noticeabily). I'm aware this is not a proper
fix for a deadlock, and just makes it less probable. I'm not
experienced with multitheaded programming and have very superficial
knowledge of python, so could not find a better fix.

Please note that while this makes the deadlock condition not show
up on my machines I can't be sure it fixes the problem on pointyhat
until tested. I hope it does though.

added file:

files/patch-wafadmin-Task.py

How-To-Repeat: 
Trying to make the audio/xmms2 port on any 9.0-BETA machine. I only
tested this on SMP machines, maybe on single core machines this is
not going to show up.
Comment 1 Martin Wilke freebsd_committer 2011-10-23 17:07:05 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 2 dfilter service freebsd_committer 2011-10-23 17:07:07 UTC
miwi        2011-10-23 16:06:54 UTC

  FreeBSD ports repository

  Modified files:
    audio/xmms2          Makefile 
  Added files:
    audio/xmms2/files    patch-wafadmin-Task.py 
  Log:
  - Fix build
  
  PR:             161591
  Submitted by:   Guido Falsi <mad@madpilot.net>
  
  Revision  Changes    Path
  1.65      +0 -4      ports/audio/xmms2/Makefile
  1.1       +18 -0     ports/audio/xmms2/files/patch-wafadmin-Task.py (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"