Bug 161791 - [patch] databases/postgresql90-server: logic for PG_USER broken on server
[patch] databases/postgresql90-server: logic for PG_USER broken on server
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Chris Rees
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-19 01:50 UTC by jhelfman
Modified: 2011-10-20 20:46 UTC (History)
0 users

See Also:


Attachments
file.diff (717 bytes, patch)
2011-10-19 01:50 UTC, jhelfman
no flags Details | Diff
patch.txt (3.08 KB, text/plain; charset=us-ascii)
2011-10-19 18:35 UTC, jhelfman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description jhelfman 2011-10-19 01:50:07 UTC
SUB_LIST was moved out of pkg-install-server and into postgresql.in, however SUB_LIST wasn't defined for PG_USER/PG_GROUP for postgresql.in
Add SUB_LIST and PLIST_SUB to test for only not client and not slave.
Comment 1 Edwin Groothuis freebsd_committer 2011-10-19 01:50:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->girgen

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 jhelfman 2011-10-19 18:35:18 UTC
Here is an updated patch for all postgresql server versions. I didn't remove
this if condition, however I believe it is no longer being used.

.  if exists(${FILESDIR}/pkg-install${PKGNAMESUFFIX}.in)
SUB_FILES+=     pkg-install${PKGNAMESUFFIX}
SUB_LIST=       PG_GROUP=$(PG_GROUP) \
                 PG_USER=$(PG_USER) \
                 PG_UID=$(PG_UID)
PLIST_SUB+=     PG_USER=$(PG_USER)
PKGINSTALL=     ${WRKDIR}/pkg-install${PKGNAMESUFFIX}
.  endif

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
Comment 3 dfilter freebsd_committer 2011-10-19 19:21:40 UTC
crees       2011-10-19 18:21:25 UTC

  FreeBSD ports repository

  Modified files:
    databases/postgresql82-server Makefile 
    databases/postgresql83-server Makefile 
    databases/postgresql84-server Makefile 
    databases/postgresql90-server Makefile 
    databases/postgresql91-server Makefile 
  Log:
  Fix SUB_LIST issue by deconditionalising it.
  
  Temporary fix, but will stop the flurry of incoming PRs related.
  
  PR:             ports/161779 ports/161774 ports/161791 ports/161771 ports/161769
  Submitted by:   Many people, original fix suggested by Jason Helfman (jhelfman@e-e.com)
  Approved by:    portmgr (pav)
  
  Revision  Changes    Path
  1.202     +4 -3      ports/databases/postgresql82-server/Makefile
  1.215     +4 -3      ports/databases/postgresql83-server/Makefile
  1.233     +4 -3      ports/databases/postgresql84-server/Makefile
  1.228     +4 -3      ports/databases/postgresql90-server/Makefile
  1.229     +4 -3      ports/databases/postgresql91-server/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Chris Rees freebsd_committer 2011-10-20 20:46:21 UTC
State Changed
From-To: open->closed

Close and take-- fixed. 


Comment 5 Chris Rees freebsd_committer 2011-10-20 20:46:21 UTC
Responsible Changed
From-To: girgen->crees

Close and take-- fixed.