Bug 161886 - [kerberos] [patch] der_xx_oid not declared before use in gss_krb5.c
Summary: [kerberos] [patch] der_xx_oid not declared before use in gss_krb5.c
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-10-21 18:20 UTC by hcoin
Modified: 2022-10-17 12:39 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hcoin 2011-10-21 18:20:10 UTC 

You will see many complaints by the compiler that der_get_oid der_free_oid
der_length_oid and der_put_oid are implicitly defined in gss_krb5.c.  No
check that the parameters in the call match what the procedure expects,
nor are any decorations about the procedure's requirements taken into account.

Fix: 

Change the makefile:

INCS=	${KRB5DIR}/lib/gssapi/gssapi/gssapi_krb5.h
-INCSDIR= ${INCLUDEDIR}/gssapi
+INCSDIR= ${INCLUDEDIR}/gssapi ${KRB5DIR}/lib/asn1

SRCS=	8003.c \


..

Change gss_krb5.c
/* RCSID("$Id: gss_krb5.c 21889 2007-08-09 07:43:24Z lha $"); */

#include <krb5.h>
#include <roken.h>
+#include <der.h>
How-To-Repeat: Do a make in /usr/src/kerberos5/lib/libgssapi_krb5, watch gss_krb5.c
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:44 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:39:08 UTC 
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>