Bug 162508 - Build fails for www/p5-Gantry if it is already installed
Summary: Build fails for www/p5-Gantry if it is already installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-12 20:20 UTC by Doug Barton
Modified: 2011-11-13 16:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Barton freebsd_committer 2011-11-12 20:20:07 UTC
	If the port is already installed I get this:

Gantry comes with a set of default templates that
need to be written to disk. A typical location for these
templates is your web server document root.

Path for Gantry templates [/usr/local/www/gantry ]
/usr/local/www/gantry 
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Gantry' version '3.64'
===>  Building for p5-Gantry-3.64
Building Gantry
rmdir: /usr/local/www/gantry: Directory not empty
*** Error code 1

Fix: 

First choice would be to fix the port so that it doesn't
	ask this question, and does the right thing on re-install.

	Second choice would be to mark it IS_INTERACTIVE and add
	CONFLICTS_BUILD on itself.
How-To-Repeat: 	See above
Comment 1 Edwin Groothuis freebsd_committer 2011-11-12 20:20:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees freebsd_committer 2011-11-12 20:36:21 UTC
I spy a much bigger issue here; it's attempting to touch the system
before the install phase.

This rmdir line is probably unnecessary-- can't it be patched out? If
it's not unnecessary, the procedure the port goes through needs
looking at; it's unacceptable for outside ${WRKDIR} to be touched at
that point.

Don't forget to moan at upstream!

Chris
Comment 3 Chris Rees freebsd_committer 2011-11-12 20:37:12 UTC
Responsible Changed
From-To: perl->crees

Didn't notice it was a perl@ port, I'll look at this one.
Comment 4 dfilter service freebsd_committer 2011-11-13 15:56:01 UTC
crees       2011-11-13 15:55:25 UTC

  FreeBSD ports repository

  Modified files:
    www/p5-Gantry        Makefile 
  Log:
  - Stop touching !WRKDIR before install phase; it's unnecessary
  - Use pre-su-install for creating directory
  
  PR:             ports/162508
  Submitted by:   dougb
  Feature safe:   yes
  
  Revision  Changes    Path
  1.18      +4 -8      ports/www/p5-Gantry/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Chris Rees freebsd_committer 2011-11-13 15:56:45 UTC
State Changed
From-To: open->closed

Looks like the creation and deletion of directories was a past issue. 
The port works fine without those lines now.  Thanks!