Bug 162539 - [patch] lang/pbasic: respect CC/CFLAGS
Summary: [patch] lang/pbasic: respect CC/CFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-13 20:50 UTC by Jan Beich
Modified: 2011-11-24 16:10 UTC (History)
0 users

See Also:


Attachments
cc.diff (703 bytes, patch)
2011-11-13 20:50 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-13 20:51:22 UTC
Maintainer of lang/pbasic,

Please note that PR ports/162539 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162539

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-13 20:51:24 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 jhs 2011-11-13 22:01:58 UTC
Hi,
Reference:
> From:		Edwin Groothuis <edwin@FreeBSD.ORG> 
> Reply-to:	bug-followup@FreeBSD.ORG 
> Date:		Sun, 13 Nov 2011 20:51:22 UT 
> Message-id:	<20111113205122.BD017106567E@hub.freebsd.org> 

Edwin Groothuis wrote:
> Maintainer of lang/pbasic,
> 
> Please note that PR ports/162539 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162539
> 
> -- 
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org

Hi,
Jan cc'd (patch submitter),
 Did you check the patch still allows builds on 8.2-RELEASE ?
 If so, Approved,
Julian S ports/lang/pbasic MAINTAINER=

PS Phil <phil@cockcroft.de> author of generic. :
Seems it's a tweak to top Makefile to make it build with latest
FreeBSD ports/ make macros in current. I haven't checked detail (as
not currently running current or 9.0-RC1). 

Cheers,
Julian
-- 
Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://berklix.com
 Reply below, not above;  Indent with "> ";  Cumulative like a play script.
 Format: Plain text. Not HTML, multipart/alternative, base64, quoted-printable.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2011-11-13 23:25:30 UTC
"Julian H. Stacey" <jhs@berklix.com> writes:

> Hi,
> Jan cc'd (patch submitter),
>  Did you check the patch still allows builds on 8.2-RELEASE ?
>  If so, Approved,
> Julian S ports/lang/pbasic MAINTAINER=

No, I don't have a local tinderbox. But it should still build fine with
gcc in base.

> PS Phil <phil@cockcroft.de> author of generic. :
> Seems it's a tweak to top Makefile to make it build with latest
> FreeBSD ports/ make macros in current. I haven't checked detail (as
> not currently running current or 9.0-RC1). 

It's not related to issues on 10.0-CURRENT. The patch aims to fix
build with redefined CC in make.conf(5) as well as leveraging
defaults CFLAGS from /usr/share/mk/sys.mk. A common user of CFLAGS
is WITH_DEBUG provided by bsd.port.mk.

  http://www.freebsd.org/doc/en/books/porters-handbook/dads-cc.html
  http://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2011-11-14 04:25:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 6 jhs 2011-11-15 02:31:25 UTC
Jan Beich wrote:
> "Julian H. Stacey" <jhs@berklix.com> writes:
> 
> > Hi,
> > Jan cc'd (patch submitter),
> >  Did you check the patch still allows builds on 8.2-RELEASE ?
> >  If so, Approved,
> > Julian S ports/lang/pbasic MAINTAINER=
> 
> No, I don't have a local tinderbox. But it should still build fine with
> gcc in base.

I applied your patch on 8.2-RELEASE.  It built, installed & ran OK on amd64.

	
> > PS Phil <phil@cockcroft.de> author of generic. :
> > Seems it's a tweak to top Makefile to make it build with latest
> > FreeBSD ports/ make macros in current. I haven't checked detail (as
> > not currently running current or 9.0-RC1). 
> 
> It's not related to issues on 10.0-CURRENT. The patch aims to fix
> build with redefined CC in make.conf(5) as well as leveraging
> defaults CFLAGS from /usr/share/mk/sys.mk. A common user of CFLAGS
> is WITH_DEBUG provided by bsd.port.mk.
> 
>   http://www.freebsd.org/doc/en/books/porters-handbook/dads-cc.html
>   http://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html

I read URLs above, looked at the effect after running make patch
(using new (Jan) post-patch: in ports/lang/pbasic/Makefile re. '='
to '+=' Looks good, Thanks :-)

The _4_ Lines beginning "post-patch" look good, ready to commit, Thanks.


Line 5:
	${ECHO_CMD} '.PHONY: $$(SYSTEMS)' >>${WRKSRC}/makefile
looks maybe wrong, we need longer to think about that last bit please.

FYI for Phil:

I'm new to .PHONY operator, but 
freebsd-8.2 man make:
     .PHONY      Apply the .PHONY attribute to any specified sources.  Targets
                 with this attribute are always considered to be out of date.
     ....
     To prevent infinite loops the following source Makefile targets are
     ignored:
     o   targets that have .PHONY or .EXEC attributes
Looking at examples
	cd /pub/FreeBSD/branches/-current/ports     
	find . -name Makefile | xargs grep '.PHONY'
		Makefile:${INDEXDIR}/${INDEXFILE}.bz2: .PHONY
		benchmarks/lmbench/files/Makefile:.PHONY:     results rerun see
		comms/predict/files/Makefile:.PHONY:  clean build
		editors/vim/Makefile:cklatest: .PHONY
	cd [8.2-RELEASE] /usr/share/mk ; grep PHONY *
		bsd.info.mk:.PHONY: ${INSTALLINFODIRS}
		bsd.obj.mk:obj: .PHONY
		bsd.subdir.mk:${SUBDIR}: .PHONY
.PHONY seen above both as 
	target to the left of ':'
	source to the right of ':'


PS When a commit is done, please also 
	s/"currently "phil@gmrs.isar.de" but changes a lot/phil@cockcroft.de/

Cheers,
Julian
-- 
Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://berklix.com
 Reply below, not above;  Indent with "> ";  Cumulative like a play script.
 Format: Plain text. Not HTML, multipart/alternative, base64, quoted-printable.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2011-11-15 13:16:01 UTC
"Julian H. Stacey" <jhs@berklix.com> writes:

> Line 5:
> 	${ECHO_CMD} '.PHONY: $$(SYSTEMS)' >>${WRKSRC}/makefile
> looks maybe wrong, we need longer to think about that last bit please.

This is done to prevent `freebsd' directory marking `freebsd' target as up to
date after touching freebsd/Makefile. Try to comment out and you'd get

  $ make
  ===>  Vulnerability check disabled, database not found
  ===>  License check disabled, port has not defined LICENSE
  ===>  Extracting for pbasic-2.0
  => SHA256 Checksum OK for pbasic-2.0-950813.tar.gz.
  ===>  Patching for pbasic-2.0
  ===>  Applying FreeBSD patches for pbasic-2.0
  ===>  Configuring for pbasic-2.0
  cd /usr/ports/lang/pbasic/work/pbasic-2.0-950813 ; /bin/rm -rf termio m68000 msdos vax pyramid ns32000  pdp11 cursor/cursor.dos cursor/cursor.ukc
  ===>  Building for pbasic-2.0
  `freebsd' is up to date.

ref. http://www.gnu.org/s/hello/manual/make/Phony-Targets.html
Comment 8 jhs 2011-11-23 23:56:15 UTC
Hi,
Reference:
> From:		Jan Beich <jbeich@tormail.net> 
> Date:		Tue, 15 Nov 2011 15:16:01 +0200 
> Message-id:	<1RQIsb-000Njp-Tl@internal.tormail.net> 

Jan Beich wrote:
> "Julian H. Stacey" <jhs@berklix.com> writes:
> 
> > Line 5:
> > 	${ECHO_CMD} '.PHONY: $$(SYSTEMS)' >>${WRKSRC}/makefile
> > looks maybe wrong, we need longer to think about that last bit please.
> 
> This is done to prevent `freebsd' directory marking `freebsd' target as up to
> date after touching freebsd/Makefile. Try to comment out and you'd get
> 
>   $ make
>   ===>  Vulnerability check disabled, database not found
>   ===>  License check disabled, port has not defined LICENSE
>   ===>  Extracting for pbasic-2.0
>   => SHA256 Checksum OK for pbasic-2.0-950813.tar.gz.
>   ===>  Patching for pbasic-2.0
>   ===>  Applying FreeBSD patches for pbasic-2.0
>   ===>  Configuring for pbasic-2.0
>   cd /usr/ports/lang/pbasic/work/pbasic-2.0-950813 ; /bin/rm -rf termio m68000 msdos vax pyramid ns32000  pdp11 cursor/cursor.dos cursor/cursor.ukc
>   ===>  Building for pbasic-2.0
>   `freebsd' is up to date.
> 
> ref. http://www.gnu.org/s/hello/manual/make/Phony-Targets.html

OK Thanks Jan, Approved
Sorry about the delay.

Cheers,
Julian
-- 
Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://berklix.com
 Reply below not above, cumulative like a play script, & indent with "> ".
 Format: Plain text. Not HTML, multipart/alternative, base64, quoted-printable.
Comment 9 Martin Wilke freebsd_committer freebsd_triage 2011-11-24 16:05:21 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 10 dfilter service freebsd_committer freebsd_triage 2011-11-24 16:05:27 UTC
miwi        2011-11-24 16:05:13 UTC

  FreeBSD ports repository

  Modified files:
    lang/pbasic          Makefile 
  Log:
  - respect CC/CFLAGS
  
  PR:             162539
  Submitted by:   Jan Beich <jbeich@tormail.net>
  Approved by:    maintainer
  Feature safe:   yes
  
  Revision  Changes    Path
  1.20      +6 -0      ports/lang/pbasic/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"