Bug 162594 - [patch] devel/lemon: respect CC
Summary: [patch] devel/lemon: respect CC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 19:40 UTC by Jan Beich
Modified: 2012-01-03 23:40 UTC (History)
0 users

See Also:


Attachments
cc.diff (820 bytes, patch)
2011-11-15 19:40 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2011-11-15 19:40:08 UTC
Currently the port does not respect CC because it ignores MAKE_ENV. And bsd.prog.mk
usage has no benefit over basic targets in sys.mk so just drop dependency on it.
While `-g' is governed by WITH_DEBUG in bsd.port.mk, i.e. the binary is always
stripped by INSTALL_PROGRAM unless STRIP is undefined/empty.

Alternatively, one can prepend ${MAKE_ENV} before ${MAKE}.

How-To-Repeat: http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.9-exp.20110723205754/lemon-1.69.log
Comment 1 Edwin Groothuis freebsd_committer 2011-11-15 19:40:26 UTC
Maintainer of devel/lemon,

Please note that PR ports/162594 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162594

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2011-11-15 19:40:28 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Vitaly Magerya 2011-11-15 20:07:29 UTC
Looks good to me, thanks.
Comment 4 Martin Wilke freebsd_committer 2011-11-15 22:53:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 5 Martin Wilke freebsd_committer 2012-01-03 23:34:37 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer 2012-01-03 23:34:39 UTC
miwi        2012-01-03 23:34:26 UTC

  FreeBSD ports repository

  Modified files:
    devel/lemon          Makefile 
  Log:
  - Respect CC
  
  PR:             162594
  Submitted by:   Jan Beich <jbeich@tormail.net>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.13      +2 -5      ports/devel/lemon/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"