Bug 162689 - devel/websvn Recreate plist and handle config files properly
Summary: devel/websvn Recreate plist and handle config files properly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-20 13:20 UTC by Chris Rees
Modified: 2011-12-04 14:30 UTC (History)
1 user (show)

See Also:


Attachments
websvn.diff (19.87 KB, patch)
2011-11-20 13:20 UTC, Chris Rees
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees freebsd_committer 2011-11-20 13:20:06 UTC
	In ports/71694 ahze@ replaced the plist with an automatically generated one, for reasons he didn't specify.  I've CC'd him to see if he had a reason that overrides my concern.
	I've corrected the pkg-message to suggest editing the correct config file (include/config.php) and added code to the Makefile and plist to copy over the distconf.php file to config.php if it doesn't exist.  This also brings back the plist, however the plist is normally only auto-generated if the port is likely to change it on install or it's huge, neither of which is the case here.
Comment 1 Edwin Groothuis freebsd_committer 2011-11-20 13:20:26 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2011-11-20 13:20:28 UTC
Maintainer of devel/websvn,

Please note that PR ports/162689 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162689

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2011-11-20 13:20:30 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Chris Rees freebsd_committer 2011-12-04 14:25:48 UTC
State Changed
From-To: feedback->closed

Committed.
Comment 5 dfilter service freebsd_committer 2011-12-04 14:25:48 UTC
crees       2011-12-04 14:25:39 UTC

  FreeBSD ports repository

  Modified files:
    devel/websvn         Makefile 
    devel/websvn/files   pkg-message.in 
  Added files:
    devel/websvn         pkg-plist 
  Log:
  - Use static plist
  - Automate distconf->config stage; port handles config files more gracefully
  - Use COPYTREE macros
  
  PR:             ports/162689
  Approved by:    maintainer timeout (ychsiao@ychsiao.org, 14 days)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.16      +9 -11     ports/devel/websvn/Makefile
  1.3       +1 -1      ports/devel/websvn/files/pkg-message.in
  1.9       +443 -0    ports/devel/websvn/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"