Bug 162798 - add p flag to newsyslog.conf
Summary: add p flag to newsyslog.conf
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-23 19:50 UTC by heas
Modified: 2018-01-30 04:50 UTC (History)
1 user (show)

See Also:
eadler: mfc-stable11?
eadler: mfc-stable10?

Attachments
file.diff (2.75 KB, patch)
2011-11-23 19:50 UTC, heas 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description heas 2011-11-23 19:50:07 UTC 
NetBSD's newsyslog.conf p flag is useful. here's a patch to add it to freebsd.

Fix: Patch attached with submission follows:
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:01:22 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-12-31 22:02:37 UTC 
A commit references this bug:

Author: eadler
Date: Sun Dec 31 22:01:37 UTC 2017
New revision: 327451
URL: https://svnweb.freebsd.org/changeset/base/327451

Log:
  newsyslog: implement 'p' flag

  Implement the 'p' flag for newsyslog from NetBSD. This flag results in
  the first log file for a given file to not be compressed.

  While here, don't change file attributes during a no-op run

  PR:		162798
  Submitted by:	heas@shrubbery.net
  MFC After:	1 month

Changes:
  head/usr.sbin/newsyslog/newsyslog.c
  head/usr.sbin/newsyslog/newsyslog.conf.5
Comment 3 Ben RUBSON 2018-01-03 09:30:49 UTC 
Thank you Eitan !
I think the following (duplicate) bug could then be closed :
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=115486
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-01-30 04:50:48 UTC 
A commit references this bug:

Author: eadler
Date: Tue Jan 30 04:50:24 UTC 2018
New revision: 328587
URL: https://svnweb.freebsd.org/changeset/base/328587

Log:
  MFC r327451:

  newsyslog: implement 'p' flag

    Implement the 'p' flag for newsyslog from NetBSD. This flag results in
    the first log file for a given file to not be compressed.

    While here, don't change file attributes during a no-op run

  PR:	162798

Changes:
_U  stable/11/
  stable/11/usr.sbin/newsyslog/newsyslog.c
  stable/11/usr.sbin/newsyslog/newsyslog.conf.5