Bug 162954 - lang/go: Fixed install when $GOBIN is set
Summary: lang/go: Fixed install when $GOBIN is set
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-29 20:40 UTC by Grzegorz Blach
Modified: 2011-11-30 20:40 UTC (History)
0 users

See Also:

Attachments
file.diff (308 bytes, patch)
2011-11-29 20:40 UTC, Grzegorz Blach 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Blach 2011-11-29 20:40:09 UTC 
When $GOBIN env variable is set lang/go port can't install binaries properly.

--- Begin Output ---
gmake: Leaving directory `/usr/ports/lang/go/work/go-20111017/src/pkg'

---
Installed Go for freebsd/386 in /usr/ports/lang/go/work/go-20111017.
Installed commands in /usr/local/bin.
The compiler is 8g.
===>  Installing for go-20111017
===>   Generating temporary packing list
===>  Checking if lang/go already installed
install -d -m 0755 /usr/local/share/doc/go
/bin/cp -R /usr/ports/lang/go/work/go-20111017/doc/ /usr/local/share/doc/go
install  -o root -g wheel -m 555 /usr/ports/lang/go/work/go-20111017/bin/* /usr/local/bin/
install: /usr/ports/lang/go/work/go-20111017/bin/*: No such file or directory
*** Error code 71

Stop in /usr/ports/lang/go.
--- End Output ---

Fix: Unset GOBIN in Makefile


Patch attached with submission follows:
How-To-Repeat: 1. Set GOBIN to some directory
> setenv GOBIN /usr/loca/bin

2. Try to install lang/go
> cd /usr/ports/lang/go && make install clean
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-29 20:40:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jlaffaye

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-11-30 20:35:27 UTC 
jlaffaye    2011-11-30 20:35:18 UTC

  FreeBSD ports repository

  Modified files:
    lang/go              Makefile pkg-plist 
  Log:
  - Install sources to fix goinstall and godoc [1] [2]
  - Unset GOBIN while installing [3]
  
  PR:             ports/154179 [1], ports/162910 [2], ports/162954 [3]
  Feature safe:   yes
  
  Revision  Changes    Path
  1.11      +4 -0      ports/lang/go/Makefile
  1.10      +1746 -0   ports/lang/go/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Julien Laffaye freebsd_committer freebsd_triage 2011-11-30 20:37:07 UTC 
State Changed
From-To: open->closed

Committed. Thanks!