Bug 163099 - devel/cvsweb: Fix detection of cgidir
Summary: devel/cvsweb: Fix detection of cgidir
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-06 20:20 UTC by Chris Rees
Modified: 2011-12-23 14:50 UTC (History)
0 users

See Also:


Attachments
cvsweb3-fix-find-location.diff (1.21 KB, patch)
2011-12-06 20:20 UTC, Chris Rees
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees freebsd_committer 2011-12-06 20:20:10 UTC
	The cvsweb Makefile doesn't actually know what PREFIX is before bsd.port.pre.mk is, so the .if exists statements always fall through to the default case (share/apache/cgi-bin in cvsweb3 and www/cgi-bin in cvsweb).
Comment 1 Edwin Groothuis freebsd_committer 2011-12-06 20:20:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2011-12-06 20:20:22 UTC
Maintainer of devel/cvsweb,

Please note that PR ports/163099 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/163099

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2011-12-06 20:20:25 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 dfilter service freebsd_committer 2011-12-23 14:45:18 UTC
crees       2011-12-23 14:45:07 UTC

  FreeBSD ports repository

  Modified files:
    devel/cvsweb         Makefile 
    devel/cvsweb3        Makefile 
  Log:
  Use bsd.port.pre.mk to allow the port to actually find the correct cgi-bindir
  without falling through to the last case every time.
  
  PR:             ports/163099
  Submitted by:   crees
  Approved by:    maintainer timeout (2w+)
  
  Revision  Changes    Path
  1.79      +3 -1      ports/devel/cvsweb/Makefile
  1.88      +3 -1      ports/devel/cvsweb3/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Chris Rees freebsd_committer 2011-12-23 14:45:23 UTC
State Changed
From-To: feedback->closed

Committed.