Bug 163286 - [PATCH] multimedia/subtitleeditor doesn't compile with gcc 4.6
Summary: [PATCH] multimedia/subtitleeditor doesn't compile with gcc 4.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 15:50 UTC by heathn
Modified: 2011-12-14 22:00 UTC (History)
0 users

See Also:

Attachments
file.diff (1.53 KB, patch)
2011-12-14 15:50 UTC, heathn 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description heathn 2011-12-14 15:50:08 UTC 
Building the port with the gcc46 compiler gives the error:

sami.cc: In member function 'void Sami::read_subtitle(FileReader&)':
sami.cc:177:32: error: taking address of temporary [-fpermissive]
gmake[4]: *** [libsami_la-sami.lo] Error 1

Fix: The original authors fixed this in their SVN repo (http://svn.gna.org/viewcvs/subtitleeditor/trunk/plugins/subtitleformats/sami/sami.cc?r1=772&r2=777).

Patch file is included which incorporates the change.

Patch attached with submission follows:
How-To-Repeat: Using the ports/lang/gcc46 compiler.

cd /usr/ports/multimedia/subtitleeditor
make

(I'm not sure if the error occurs on previous versions of the gcc compiler.)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-14 15:50:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2011-12-14 21:52:15 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-12-14 21:52:28 UTC 
ehaupt      2011-12-14 21:52:09 UTC

  FreeBSD ports repository

  Added files:
    multimedia/subtitleeditor/files 
                                    patch-plugins__subtitleformats__sami__sami.cc 
  Log:
  Fix build with gcc46
  
  PR:             163286
  Submitted by:   Heath Nielson <heathn@gmail.com>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.1       +56 -0     ports/multimedia/subtitleeditor/files/patch-plugins__subtitleformats__sami__sami.cc (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"