Bug 163610 - Patch for proxy regression in net/liferea 1.8.0
Patch for proxy regression in net/liferea 1.8.0
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: pav
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-25 15:00 UTC by fk
Modified: 2011-12-26 17:30 UTC (History)
0 users

See Also:


Attachments
file.diff (1.98 KB, patch)
2011-12-25 15:00 UTC, fk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fk 2011-12-25 15:00:26 UTC
There's a regression in Liferea 1.8.0 that causes it to ignore the proxy
settings for requests made though the feed item viewer. The configured HTTP
proxy is used to update the feeds, though.

This has been fixed upstream in:
http://liferea.git.sourceforge.net/git/gitweb.cgi?p=liferea/liferea;a=patch;h=137604683770cae900d5835befefd95c65866cd7;hp=b509074806afbf5f0ee3f36db8e112c1ea20cdac

The attached patch "backports" this fix.

Fix: Apply the patch (with -p0).

You may want to shorten the patch it creates in net/liferea/files to the
src/ui/liferea_htmlview.c chunk. I kept it as-is so comparing with the source
is easier. It was created with: git format-patch --no-prefix
137604683^..137604683

Patch attached with submission follows:
How-To-Repeat: Configure a HTTP proxy in Liferea, read a feed item with embedded images and
watch the network traffic.

In environments where direct HTTP requests from common applications are
redirected or blocked and DNS requests are made through Tor, the image requests
will also take longer than usual and occasionally timeout.
Comment 1 Edwin Groothuis freebsd_committer 2011-12-25 15:00:37 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 pav freebsd_committer 2011-12-26 17:25:52 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter freebsd_committer 2011-12-26 17:26:36 UTC
pav         2011-12-26 17:26:23 UTC

  FreeBSD ports repository

  Modified files:
    net/liferea          Makefile 
  Added files:
    net/liferea/files    patch-proxy-fix-1376046 
  Log:
  - Backport a vendor patch to respect HTTP proxy settings in HTML widget
  
  PR:             ports/163610
  Submitted by:   Fabian Keil <fk@fabiankeil.de>
  
  Revision  Changes    Path
  1.156     +1 -0      ports/net/liferea/Makefile
  1.1       +45 -0     ports/net/liferea/files/patch-proxy-fix-1376046 (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"