Bug 163726 - sysutils/hal fills device_revision_bcd incorrectly
Summary: sysutils/hal fills device_revision_bcd incorrectly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
Depends on:
Reported: 2011-12-31 01:40 UTC by Stephen Hurd
Modified: 2012-01-02 19:10 UTC (History)
0 users

See Also:

file.diff (1.29 KB, patch)
2011-12-31 01:40 UTC, Stephen Hurd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Hurd freebsd_committer 2011-12-31 01:40:07 UTC
The probe-usb2-device.c:191 (as patched) fills the device revision BCD field using the USB bcd data, resulting in incorrect data being used for matching and the device revision being unavailable to clients.

Fix: Change line 191 to use bcdDevice rather than bcdUSB.

Updated patch for files directory attached.

Patch attached with submission follows:
How-To-Repeat: Compare the output of "lhsal" usb_devuce.device_revision_bcd fields to the corresponding "usbconfig dump_device_desc" bcdDevice field.
Comment 1 Edwin Groothuis freebsd_committer 2011-12-31 01:40:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Joe Marcus Clarke freebsd_committer 2012-01-02 19:01:25 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer 2012-01-02 19:01:28 UTC
marcus      2012-01-02 19:01:19 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/hal         Makefile 
    sysutils/hal/files   patch-hald_freebsd_probe-usb2-device.c 
  Correctly populate usb_device.device_revision_bcd.
  PR:             163726
  Submitted by:   Stephen Hurd <shurd@sasktel.net>
  Reviewed by:    hps
  Revision  Changes    Path
  1.75      +1 -1      ports/sysutils/hal/Makefile
  1.2       +11 -2     ports/sysutils/hal/files/patch-hald_freebsd_probe-usb2-device.c
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"