Bug 164181 - [PATCH] www/xxxterm: Fix ssl_ca_file path and style
Summary: [PATCH] www/xxxterm: Fix ssl_ca_file path and style
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-15 18:40 UTC by Winston Weinert
Modified: 2012-09-11 02:48 UTC (History)
0 users

See Also:


Attachments
file.diff (1.40 KB, patch)
2012-01-15 18:40 UTC, Winston Weinert
no flags Details | Diff
patch.txt (1.32 KB, TEXT/PLAIN; charset=US-ASCII)
2012-01-15 20:55 UTC, Winston Weinert
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Winston Weinert 2012-01-15 18:40:12 UTC
Though www/xxxterm depends on security/ca_root_nss, it does not by default use the SSL certificate file provided by security/ca_root_nss. This means www/xxxterm could be misconfigured out of the box and consequently never checks HTTPS websites' certificates for authenticity.

Cleaned up the Makefile by removing a distracting comment and removing a parenthesis pair that isn't necessary. Added 'PORTREVISION= 1' to the Makefile since this is a revision to the port, not an update.

Fix: echo 'ssl_ca_file = /usr/local/share/certs/ca-root-nss.crt' >> $HOME/.xxxterm.conf


Patch attached with submission follows:
How-To-Repeat: Load a HTTPS website; get red bar (indicates possibly insecure connection) on known verified site.
Comment 1 Winston Weinert 2012-01-15 20:55:08 UTC
Oops! I jumped the gun! Attached is a patch that sets ssl_ca_file in 
xxxterm.c instead of incorrectly in settings.c. The previous patch causes 
xxxterm to exit with "Bus error (core dumped)" if ssl_ca_file is set in 
~/.xxxterm.conf. Sorry about the mix up!
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-26 02:58:01 UTC
Maintainer of www/xxxterm,

Please note that PR ports/164181 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164181

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-26 02:58:02 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2012-03-05 22:34:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->eadler

I'll take it.
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2012-05-06 15:35:45 UTC
State Changed
From-To: feedback->open

feedback timeout
Comment 6 Eitan Adler freebsd_committer freebsd_triage 2012-06-24 22:16:54 UTC
State Changed
From-To: open->feedback

sorry for the delay, the patch you supplied didn't apply cleanly and I 
didn't have a chance to look into it now: the patch to xxxterm doesn't 
apply at all. Can you resubmit?
Comment 7 Eitan Adler freebsd_committer freebsd_triage 2012-09-11 02:48:40 UTC
State Changed
From-To: feedback->closed

feedback timeout - if this is still an issue please correct the error 
and email me