Bug 165348 - converters/libiconv solve problem related to C++
Summary: converters/libiconv solve problem related to C++
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 04:30 UTC by Pedro F. Giffuni
Modified: 2012-03-05 00:00 UTC (History)
0 users

See Also:

Attachments
file.diff (1.22 KB, patch)
2012-02-21 04:30 UTC, Pedro F. Giffuni 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni 2012-02-21 04:30:10 UTC 
While building Apache OpenOffice we repeatedly saw a nasty error related
to the use of the iconv header with C++:
https://issues.apache.org/ooo/show_bug.cgi?id=118574

Fix: Upstream author has acknowledged the error and says it was fixed for
libiconv 1.14:
http://git.savannah.gnu.org/gitweb/?p=libiconv.git;a=commitdiff;h=a47098b3779b9febf25e8a5ba1b0407e29d67acf

Of course updating libiconv would solve the problem but for the
time being the attached patch adds the fix to the current version
1.13.1.


Patch attached with submission follows:
How-To-Repeat: This is easy to reproduce in FreeBSD but it went noticed because linux
uses a different libiconv from glibc.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-21 04:30:22 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2012-03-04 23:57:03 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-03-04 23:57:24 UTC 
marcus      2012-03-04 23:56:56 UTC

  FreeBSD ports repository

  Added files:
    converters/libiconv/files patch-include_iconv.h.in 
  Log:
  Fix building C++ code that uses libiconv.
  
  PR:             165348
  Submitted by:   Pedro Giffuni <giffunip@tutopia.com>
  
  Revision  Changes    Path
  1.1       +43 -0     ports/converters/libiconv/files/patch-include_iconv.h.in (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"