Bug 165692 - nd6_nud_hint() a NOP due to removal of route caching
Summary: nd6_nud_hint() a NOP due to removal of route caching
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-04 19:10 UTC by Bjoern A. Zeeb
Modified: 2017-12-31 22:24 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bjoern A. Zeeb freebsd_committer freebsd_triage 2012-03-04 19:10:10 UTC
When removing route caching from the pcbs nd6_nud_hint() was called with two NULL pointers for rt and dst6 (and has probably only been called with rt before).  Since the code in nd6_nud_hint() was changed as well and the entire function calls are now effectively NOPs as all mandatory options are missing.

Fix: 

Once PCB route caching is back cann nd6_nud_hint() with proper arguments again.
How-To-Repeat: Index: sys/netinet/tcp_input.c
===================================================================
--- sys/netinet/tcp_input.c	(revision 232512)
+++ sys/netinet/tcp_input.c	(working copy)
@@ -457,6 +457,7 @@ tcp_signature_verify_input(struct mbuf *m, int off
 
 /* Neighbor Discovery, Neighbor Unreachability Detection Upper layer hint. */
 #ifdef INET6
+/* XXX-BZ useless without rt and dst6. Fix route chaching removal. */
 #define ND6_HINT(tp) \
 do { \
 	if ((tp) && (tp)->t_inpcb && \
Index: sys/netinet/tcp_var.h
===================================================================
--- sys/netinet/tcp_var.h	(revision 232512)
+++ sys/netinet/tcp_var.h	(working copy)
@@ -85,6 +85,7 @@ struct tcptemp {
 
 /* Neighbor Discovery, Neighbor Unreachability Detection Upper layer hint. */
 #ifdef INET6
+/* XXX-BZ useless without rt and dst6. Fix route chaching removal. */
 #define ND6_HINT(tp)						\
 do {								\
 	if ((tp) && (tp)->t_inpcb &&				\
Index: sys/netinet6/nd6.c
===================================================================
--- sys/netinet6/nd6.c	(revision 232514)
+++ sys/netinet6/nd6.c	(working copy)
@@ -1136,6 +1136,8 @@ nd6_nud_hint(struct rtentry *rt, struct in6_addr *
 	if ((dst6 == NULL) || (rt == NULL))
 		return;
 
+	/* NOTREACHED. XXX-BZ Fix route chaching removal. */
+
 	ifp = rt->rt_ifp;
 	IF_AFDATA_LOCK(ifp);
 	ln = nd6_lookup(dst6, ND6_EXCLUSIVE, NULL);
Comment 1 Bjoern A. Zeeb freebsd_committer freebsd_triage 2012-03-04 19:28:20 UTC
Responsible Changed
From-To: freebsd-bugs->bz

Claim; it's my own and it's to remind me to fix it once the 
infrastructure will be back to do so.
Comment 2 Bjoern A. Zeeb freebsd_committer freebsd_triage 2014-05-18 05:59:12 UTC
Responsible Changed
From-To: bz->gnn

I shall not use bugzilla (at least until we will have a CLI).
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:14 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped