When removing route caching from the pcbs nd6_nud_hint() was called with two NULL pointers for rt and dst6 (and has probably only been called with rt before). Since the code in nd6_nud_hint() was changed as well and the entire function calls are now effectively NOPs as all mandatory options are missing. Fix: Once PCB route caching is back cann nd6_nud_hint() with proper arguments again. How-To-Repeat: Index: sys/netinet/tcp_input.c =================================================================== --- sys/netinet/tcp_input.c (revision 232512) +++ sys/netinet/tcp_input.c (working copy) @@ -457,6 +457,7 @@ tcp_signature_verify_input(struct mbuf *m, int off /* Neighbor Discovery, Neighbor Unreachability Detection Upper layer hint. */ #ifdef INET6 +/* XXX-BZ useless without rt and dst6. Fix route chaching removal. */ #define ND6_HINT(tp) \ do { \ if ((tp) && (tp)->t_inpcb && \ Index: sys/netinet/tcp_var.h =================================================================== --- sys/netinet/tcp_var.h (revision 232512) +++ sys/netinet/tcp_var.h (working copy) @@ -85,6 +85,7 @@ struct tcptemp { /* Neighbor Discovery, Neighbor Unreachability Detection Upper layer hint. */ #ifdef INET6 +/* XXX-BZ useless without rt and dst6. Fix route chaching removal. */ #define ND6_HINT(tp) \ do { \ if ((tp) && (tp)->t_inpcb && \ Index: sys/netinet6/nd6.c =================================================================== --- sys/netinet6/nd6.c (revision 232514) +++ sys/netinet6/nd6.c (working copy) @@ -1136,6 +1136,8 @@ nd6_nud_hint(struct rtentry *rt, struct in6_addr * if ((dst6 == NULL) || (rt == NULL)) return; + /* NOTREACHED. XXX-BZ Fix route chaching removal. */ + ifp = rt->rt_ifp; IF_AFDATA_LOCK(ifp); ln = nd6_lookup(dst6, ND6_EXCLUSIVE, NULL);
Responsible Changed From-To: freebsd-bugs->bz Claim; it's my own and it's to remind me to fix it once the infrastructure will be back to do so.
Responsible Changed From-To: bz->gnn I shall not use bugzilla (at least until we will have a CLI).
For bugs matching the following criteria: Status: In Progress Changed: (is less than) 2014-06-01 Reset to default assignee and clear in-progress tags. Mail being skipped