Bug 165702 - [maintainer update] [patch] devel/ice: Support clang and gcc47, security fixes, cleanup
Summary: [maintainer update] [patch] devel/ice: Support clang and gcc47, security fixe...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 03:30 UTC by Michael Gmelin
Modified: 2012-03-24 16:00 UTC (History)
0 users

See Also:


Attachments
Ice-3.4.2_2.patch (87.83 KB, patch)
2012-03-05 03:30 UTC, Michael Gmelin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin 2012-03-05 03:30:06 UTC
This update fixes a list of issues with devel/ice:

1. Support compilation with standards-compliant C++ compilers, especially lang/clang
   and lang/gcc4.7. This requires substantial changes which are fortunately
   backwards compatible, so compilation with older versions of gcc (especially gcc
   4.2.1) still works as expected.

   See also:
   http://www.zeroc.com/forums/patches/5647-patch-compiling-ice-clang-gcc4-7-a.html

2. Patch to fix a critical memory leak in Glacier2 (Ice's firewall traversal
   service).

   See also:
   http://www.zeroc.com/forums/patches/5627-patch-3-ice-3-4-2-glacier2-memory-leak.html

3. Security patch to IceGrid (Ice's grid computing solution) to prevent node
   and registry name spoofing.

   See also:
   http://www.zeroc.com/forums/patches/5663-patch-prevent-icegrid-node-registry-replica-name-spoofing.html

4. Patches to Ice's unit tests to make them aware of FreeBSD. Add jail
   detection to disable unit tests that won't run inside of a jail.

   See also:
   http://www.zeroc.com/forums/patches/5646-improvements-unit-tests-fix-encoding-freebsd-support.html

5. Change Makefile so it actually runs Ice's unit tests. Until now these only
   have been compiled (which is time consuming) but never run. Add OPTIONS
   to allow the user to disable compilation of unit tests and demos to save
   build time. Provide test and regression-test targets.

Added file(s):
- files/patch-cpp-allTests.py
- files/patch-cpp-demo-IceGrid-secure-README
- files/patch-cpp-demo-IceGrid-secure-application.xml
- files/patch-cpp-demo-IceGrid-secure-config.admin
- files/patch-cpp-demo-IceGrid-secure-config.client
- files/patch-cpp-demo-IceGrid-secure-config.master
- files/patch-cpp-demo-IceGrid-secure-config.node
- files/patch-cpp-demo-IceGrid-secure-config.registry
- files/patch-cpp-demo-IceGrid-secure-config.slave
- files/patch-cpp-demo-IceGrid-secure-makecerts.py
- files/patch-cpp-include-Freeze-Map.h
- files/patch-cpp-include-Ice-Buffer.h
- files/patch-cpp-include-Ice-ConnectionIF.h
- files/patch-cpp-include-Ice-IconvStringConverter.h
- files/patch-cpp-include-Ice-IncomingAsyncF.h
- files/patch-cpp-include-Ice-LocalObjectF.h
- files/patch-cpp-include-Ice-ObjectF.h
- files/patch-cpp-include-Ice-OutgoingAsyncF.h
- files/patch-cpp-include-Ice-Proxy.h
- files/patch-cpp-include-Ice-ProxyF.h
- files/patch-cpp-include-Ice-Stream.h
- files/patch-cpp-include-Ice-StreamF.h
- files/patch-cpp-include-IceUtil-Mutex.h
- files/patch-cpp-src-Freeze-MapDb.cpp
- files/patch-cpp-src-Freeze-MapI.cpp
- files/patch-cpp-src-Freeze-SharedDbEnv.cpp
- files/patch-cpp-src-Glacier2-Blobject.cpp
- files/patch-cpp-src-Glacier2-Blobject.h
- files/patch-cpp-src-Glacier2-RequestQueue.cpp
- files/patch-cpp-src-Glacier2-RequestQueue.h
- files/patch-cpp-src-Glacier2-RouterI.cpp
- files/patch-cpp-src-Ice-ConnectionI.cpp
- files/patch-cpp-src-Ice-IncomingAsync.cpp
- files/patch-cpp-src-Ice-LocalObject.cpp
- files/patch-cpp-src-Ice-Object.cpp
- files/patch-cpp-src-Ice-OutgoingAsync.cpp
- files/patch-cpp-src-Ice-PropertyNames.cpp
- files/patch-cpp-src-Ice-PropertyNames.h
- files/patch-cpp-src-Ice-ProxyFactory.cpp
- files/patch-cpp-src-Ice-Service.cpp
- files/patch-cpp-src-Ice-Stream.cpp
- files/patch-cpp-src-IceGrid-AdminCallbackRouter.cpp
- files/patch-cpp-src-IceGrid-DescriptorHelper.cpp
- files/patch-cpp-src-IceGrid-Internal.ice
- files/patch-cpp-src-IceGrid-InternalRegistryI.cpp
- files/patch-cpp-src-IceGrid-InternalRegistryI.h
- files/patch-cpp-src-IceGrid-NodeSessionManager.cpp
- files/patch-cpp-src-IceGrid-ReplicaCache.cpp
- files/patch-cpp-src-IceGrid-ReplicaSessionManager.cpp
- files/patch-cpp-src-IceGrid-SessionI.h
- files/patch-cpp-src-IceSSL-Instance.cpp
- files/patch-cpp-src-IceSSL-InstanceF.h
- files/patch-cpp-src-IceSSL-TrustManager.cpp
- files/patch-cpp-src-IceSSL-TrustManagerF.h
- files/patch-cpp-src-IceSSL-Util.cpp
- files/patch-cpp-src-IceSSL-UtilF.h
- files/patch-cpp-src-IceStorm-NodeI.cpp
- files/patch-cpp-src-IceUtil-Cond.cpp
- files/patch-cpp-src-IceUtil-CountDownLatch.cpp
- files/patch-cpp-src-IceUtil-CtrlCHandler.cpp
- files/patch-cpp-src-IceUtil-FileUtil.cpp
- files/patch-cpp-src-IceUtil-RecMutex.cpp
- files/patch-cpp-src-Slice-CPlusPlusUtil.cpp
- files/patch-cpp-src-Slice-FileTracker.cpp
- files/patch-cpp-src-slice2cpp-Gen.cpp
- files/patch-cpp-src-slice2cs-Gen.cpp
- files/patch-cpp-src-slice2java-Gen.cpp
- files/patch-cpp-test-Glacier2-ssl-Server.cpp
- files/patch-cpp-test-Ice-background-EndpointI.h
- files/patch-cpp-test-Ice-custom-AllTests.cpp
- files/patch-cpp-test-Ice-info-AllTests.cpp
- files/patch-cpp-test-Ice-properties-run.py
- files/patch-cpp-test-IceUtil-unicode-Client.cpp
- files/patch-cpp-test-Slice-keyword-Client.cpp
- files/patch-cpp-test-include-TestCommon.h
- files/patch-scripts-TestUtil.py

Generated with FreeBSD Port Tools 0.99_4 (mode: change, diff: suffix)

Fix: Apply the following patch by doing:

cd /usr/ports/devel/ice
patch -p0 < /path/to/Ice-3.4.2_2.patch
How-To-Repeat: Check resources given in the description.
Comment 1 Edwin Groothuis freebsd_committer 2012-03-05 03:30:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2012-03-24 15:57:50 UTC
miwi        2012-03-24 15:57:40 UTC

  FreeBSD ports repository

  Modified files:
    devel/ice            Makefile 
    devel/ice/files      patch-Makefile 
  Added files:
    devel/ice/files      patch-cpp-allTests.py 
                         patch-cpp-demo-IceGrid-secure-README 
                         patch-cpp-demo-IceGrid-secure-application.xml 
                         patch-cpp-demo-IceGrid-secure-config.admin 
                         patch-cpp-demo-IceGrid-secure-config.client 
                         patch-cpp-demo-IceGrid-secure-config.master 
                         patch-cpp-demo-IceGrid-secure-config.node 
                         patch-cpp-demo-IceGrid-secure-config.registry 
                         patch-cpp-demo-IceGrid-secure-config.slave 
                         patch-cpp-demo-IceGrid-secure-makecerts.py 
                         patch-cpp-include-Freeze-Map.h 
                         patch-cpp-include-Ice-Buffer.h 
                         patch-cpp-include-Ice-ConnectionIF.h 
                         patch-cpp-include-Ice-IconvStringConverter.h 
                         patch-cpp-include-Ice-IncomingAsyncF.h 
                         patch-cpp-include-Ice-LocalObjectF.h 
                         patch-cpp-include-Ice-ObjectF.h 
                         patch-cpp-include-Ice-OutgoingAsyncF.h 
                         patch-cpp-include-Ice-Proxy.h 
                         patch-cpp-include-Ice-ProxyF.h 
                         patch-cpp-include-Ice-Stream.h 
                         patch-cpp-include-Ice-StreamF.h 
                         patch-cpp-include-IceUtil-Mutex.h 
                         patch-cpp-src-Freeze-MapDb.cpp 
                         patch-cpp-src-Freeze-MapI.cpp 
                         patch-cpp-src-Freeze-SharedDbEnv.cpp 
                         patch-cpp-src-Glacier2-Blobject.cpp 
                         patch-cpp-src-Glacier2-Blobject.h 
                         patch-cpp-src-Glacier2-RequestQueue.cpp 
                         patch-cpp-src-Glacier2-RequestQueue.h 
                         patch-cpp-src-Glacier2-RouterI.cpp 
                         patch-cpp-src-Ice-ConnectionI.cpp 
                         patch-cpp-src-Ice-IncomingAsync.cpp 
                         patch-cpp-src-Ice-LocalObject.cpp 
                         patch-cpp-src-Ice-Object.cpp 
                         patch-cpp-src-Ice-OutgoingAsync.cpp 
                         patch-cpp-src-Ice-PropertyNames.cpp 
                         patch-cpp-src-Ice-PropertyNames.h 
                         patch-cpp-src-Ice-ProxyFactory.cpp 
                         patch-cpp-src-Ice-Service.cpp 
                         patch-cpp-src-Ice-Stream.cpp 
                         patch-cpp-src-IceGrid-AdminCallbackRouter.cpp 
                         patch-cpp-src-IceGrid-DescriptorHelper.cpp 
                         patch-cpp-src-IceGrid-Internal.ice 
                         patch-cpp-src-IceGrid-InternalRegistryI.cpp 
                         patch-cpp-src-IceGrid-InternalRegistryI.h 
                         patch-cpp-src-IceGrid-NodeSessionManager.cpp 
                         patch-cpp-src-IceGrid-ReplicaCache.cpp 
                         patch-cpp-src-IceGrid-ReplicaSessionManager.cpp 
                         patch-cpp-src-IceGrid-SessionI.h 
                         patch-cpp-src-IceSSL-Instance.cpp 
                         patch-cpp-src-IceSSL-InstanceF.h 
                         patch-cpp-src-IceSSL-TrustManager.cpp 
                         patch-cpp-src-IceSSL-TrustManagerF.h 
                         patch-cpp-src-IceSSL-Util.cpp 
                         patch-cpp-src-IceSSL-UtilF.h 
                         patch-cpp-src-IceStorm-NodeI.cpp 
                         patch-cpp-src-IceUtil-Cond.cpp 
                         patch-cpp-src-IceUtil-CountDownLatch.cpp 
                         patch-cpp-src-IceUtil-CtrlCHandler.cpp 
                         patch-cpp-src-IceUtil-FileUtil.cpp 
                         patch-cpp-src-IceUtil-RecMutex.cpp 
                         patch-cpp-src-Slice-CPlusPlusUtil.cpp 
                         patch-cpp-src-Slice-FileTracker.cpp 
                         patch-cpp-src-slice2cpp-Gen.cpp 
                         patch-cpp-src-slice2cs-Gen.cpp 
                         patch-cpp-src-slice2java-Gen.cpp 
                         patch-cpp-test-Glacier2-ssl-Server.cpp 
                         patch-cpp-test-Ice-background-EndpointI.h 
                         patch-cpp-test-Ice-custom-AllTests.cpp 
                         patch-cpp-test-Ice-info-AllTests.cpp 
                         patch-cpp-test-Ice-properties-run.py 
                         patch-cpp-test-IceUtil-unicode-Client.cpp 
                         patch-cpp-test-Slice-keyword-Client.cpp 
                         patch-cpp-test-include-TestCommon.h 
                         patch-scripts-TestUtil.py 
  Log:
  - Fix build with gcc 4.7
  - Add support for clang
  
  PR:             165702
  Submitted by:   Michael Gmelin <freebsd@grem.de> (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.22      +26 -1     ports/devel/ice/Makefile
  1.7       +18 -4     ports/devel/ice/files/patch-Makefile
  1.1       +30 -0     ports/devel/ice/files/patch-cpp-allTests.py (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-README (new)
  1.1       +13 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-application.xml (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-config.admin (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-config.client (new)
  1.1       +64 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-config.master (new)
  1.1       +19 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-config.node (new)
  1.1       +57 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-config.registry (new)
  1.1       +69 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-config.slave (new)
  1.1       +14 -0     ports/devel/ice/files/patch-cpp-demo-IceGrid-secure-makecerts.py (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-include-Freeze-Map.h (new)
  1.1       +10 -0     ports/devel/ice/files/patch-cpp-include-Ice-Buffer.h (new)
  1.1       +17 -0     ports/devel/ice/files/patch-cpp-include-Ice-ConnectionIF.h (new)
  1.1       +21 -0     ports/devel/ice/files/patch-cpp-include-Ice-IconvStringConverter.h (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-include-Ice-IncomingAsyncF.h (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-include-Ice-LocalObjectF.h (new)
  1.1       +22 -0     ports/devel/ice/files/patch-cpp-include-Ice-ObjectF.h (new)
  1.1       +17 -0     ports/devel/ice/files/patch-cpp-include-Ice-OutgoingAsyncF.h (new)
  1.1       +56 -0     ports/devel/ice/files/patch-cpp-include-Ice-Proxy.h (new)
  1.1       +76 -0     ports/devel/ice/files/patch-cpp-include-Ice-ProxyF.h (new)
  1.1       +79 -0     ports/devel/ice/files/patch-cpp-include-Ice-Stream.h (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-include-Ice-StreamF.h (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-include-IceUtil-Mutex.h (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-src-Freeze-MapDb.cpp (new)
  1.1       +41 -0     ports/devel/ice/files/patch-cpp-src-Freeze-MapI.cpp (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-src-Freeze-SharedDbEnv.cpp (new)
  1.1       +18 -0     ports/devel/ice/files/patch-cpp-src-Glacier2-Blobject.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-Glacier2-Blobject.h (new)
  1.1       +74 -0     ports/devel/ice/files/patch-cpp-src-Glacier2-RequestQueue.cpp (new)
  1.1       +23 -0     ports/devel/ice/files/patch-cpp-src-Glacier2-RequestQueue.h (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-src-Glacier2-RouterI.cpp (new)
  1.1       +27 -0     ports/devel/ice/files/patch-cpp-src-Ice-ConnectionI.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-Ice-IncomingAsync.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-Ice-LocalObject.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-Ice-Object.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-Ice-OutgoingAsync.cpp (new)
  1.1       +20 -0     ports/devel/ice/files/patch-cpp-src-Ice-PropertyNames.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-Ice-PropertyNames.h (new)
  1.1       +10 -0     ports/devel/ice/files/patch-cpp-src-Ice-ProxyFactory.cpp (new)
  1.1       +32 -0     ports/devel/ice/files/patch-cpp-src-Ice-Service.cpp (new)
  1.1       +24 -0     ports/devel/ice/files/patch-cpp-src-Ice-Stream.cpp (new)
  1.1       +16 -0     ports/devel/ice/files/patch-cpp-src-IceGrid-AdminCallbackRouter.cpp (new)
  1.1       +35 -0     ports/devel/ice/files/patch-cpp-src-IceGrid-DescriptorHelper.cpp (new)
  1.1       +20 -0     ports/devel/ice/files/patch-cpp-src-IceGrid-Internal.ice (new)
  1.1       +136 -0    ports/devel/ice/files/patch-cpp-src-IceGrid-InternalRegistryI.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-IceGrid-InternalRegistryI.h (new)
  1.1       +17 -0     ports/devel/ice/files/patch-cpp-src-IceGrid-NodeSessionManager.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-IceGrid-ReplicaCache.cpp (new)
  1.1       +17 -0     ports/devel/ice/files/patch-cpp-src-IceGrid-ReplicaSessionManager.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-IceGrid-SessionI.h (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-IceSSL-Instance.cpp (new)
  1.1       +17 -0     ports/devel/ice/files/patch-cpp-src-IceSSL-InstanceF.h (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-IceSSL-TrustManager.cpp (new)
  1.1       +17 -0     ports/devel/ice/files/patch-cpp-src-IceSSL-TrustManagerF.h (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-src-IceSSL-Util.cpp (new)
  1.1       +17 -0     ports/devel/ice/files/patch-cpp-src-IceSSL-UtilF.h (new)
  1.1       +14 -0     ports/devel/ice/files/patch-cpp-src-IceStorm-NodeI.cpp (new)
  1.1       +15 -0     ports/devel/ice/files/patch-cpp-src-IceUtil-Cond.cpp (new)
  1.1       +21 -0     ports/devel/ice/files/patch-cpp-src-IceUtil-CountDownLatch.cpp (new)
  1.1       +49 -0     ports/devel/ice/files/patch-cpp-src-IceUtil-CtrlCHandler.cpp (new)
  1.1       +13 -0     ports/devel/ice/files/patch-cpp-src-IceUtil-FileUtil.cpp (new)
  1.1       +28 -0     ports/devel/ice/files/patch-cpp-src-IceUtil-RecMutex.cpp (new)
  1.1       +20 -0     ports/devel/ice/files/patch-cpp-src-Slice-CPlusPlusUtil.cpp (new)
  1.1       +13 -0     ports/devel/ice/files/patch-cpp-src-Slice-FileTracker.cpp (new)
  1.1       +111 -0    ports/devel/ice/files/patch-cpp-src-slice2cpp-Gen.cpp (new)
  1.1       +28 -0     ports/devel/ice/files/patch-cpp-src-slice2cs-Gen.cpp (new)
  1.1       +20 -0     ports/devel/ice/files/patch-cpp-src-slice2java-Gen.cpp (new)
  1.1       +43 -0     ports/devel/ice/files/patch-cpp-test-Glacier2-ssl-Server.cpp (new)
  1.1       +11 -0     ports/devel/ice/files/patch-cpp-test-Ice-background-EndpointI.h (new)
  1.1       +32 -0     ports/devel/ice/files/patch-cpp-test-Ice-custom-AllTests.cpp (new)
  1.1       +31 -0     ports/devel/ice/files/patch-cpp-test-Ice-info-AllTests.cpp (new)
  1.1       +18 -0     ports/devel/ice/files/patch-cpp-test-Ice-properties-run.py (new)
  1.1       +13 -0     ports/devel/ice/files/patch-cpp-test-IceUtil-unicode-Client.cpp (new)
  1.1       +20 -0     ports/devel/ice/files/patch-cpp-test-Slice-keyword-Client.cpp (new)
  1.1       +25 -0     ports/devel/ice/files/patch-cpp-test-include-TestCommon.h (new)
  1.1       +44 -0     ports/devel/ice/files/patch-scripts-TestUtil.py (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Wilke freebsd_committer 2012-03-24 15:57:51 UTC
State Changed
From-To: open->closed

Committed. Thanks!