Bug 165993 - [patch] missorted SUBDIR in lang/Makefile
Summary: [patch] missorted SUBDIR in lang/Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-13 05:20 UTC by Conrad J. Sabatier
Modified: 2012-03-13 16:20 UTC (History)
0 users

See Also:


Attachments
patch-ports-lang-Makefile (573 bytes, text/plain)
2012-03-13 05:20 UTC, Conrad J. Sabatier
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad J. Sabatier 2012-03-13 05:20:01 UTC
The item "perl5.8" is lexicographically greater than perl5.10, perl5.12 
and perl5.14, and should follow, not precede them in the Makefile.  I can 
understand how such a mistake could easily be made, if one is considering 
only the version numbers and mentally performing a numeric sort, but 
nonetheless, it should come after.

My "mkreadmes" program helped me spot this, as it left several error 
messages in the log file from last night's ports tree update:

Port lang/perl5.10 not found in INDEX
Port lang/perl5.12 not found in INDEX
Port lang/perl5.14 not found in INDEX

Of course these are, in fact, in the index, but mkreadmes relies on 
having properly sorted Makefiles as part of its search optimization 
strategy.  A missorted item will cause it to bypass other items that 
should have preceded it.

Fix: patch below
How-To-Repeat: 
N/A
Comment 1 Philip M. Gollucci freebsd_committer freebsd_triage 2012-03-13 05:28:53 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

I will take it.
Comment 2 Philip M. Gollucci freebsd_committer freebsd_triage 2012-03-13 16:19:20 UTC
State Changed
From-To: open->closed

Committed, Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-03-13 16:19:51 UTC
pgollucci    2012-03-13 16:19:11 UTC

  FreeBSD ports repository

  Modified files:
    lang                 Makefile 
  Log:
  - Sort lang/Makefile
  
  PR:             ports/165993
  Submitted by:   "Conrad J. Sabatier" <conrads@cox.net>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.769     +1 -1      ports/lang/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"