Bug 166722 - graphics/ufraw: port fails to build if "GTK" option is disabled and x11-toolkits/gtkimageview port is not installed
Summary: graphics/ufraw: port fails to build if "GTK" option is disabled and x11-toolk...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-07 14:10 UTC by Bojan Petrovic
Modified: 2012-06-11 09:10 UTC (History)
0 users

See Also:


Attachments
file.txt (277 bytes, text/plain)
2012-04-07 14:10 UTC, Bojan Petrovic
no flags Details
ufraw.patch (580 bytes, patch)
2012-05-25 10:59 UTC, Rodrigo OSORIO
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bojan Petrovic 2012-04-07 14:10:01 UTC
Configuration step fails when building graphics/ufraw port with "GTK" option disabled, if x11-toolkits/gtkimageview port is not installed.

Fix: Explicitly disable GTK support with "--with-gtk=no" configure switch.

Patch attached with submission follows:
How-To-Repeat: Uninstall x11-toolkits/gtkimageview, configure the graphics/ufraw port with "GTK" option disabled, and try to build the port.
Comment 1 Michael Scheidell freebsd_committer freebsd_triage 2012-04-21 10:43:07 UTC
Thank you for your submission and problem report.  We appreciate your 
support of the FreeBSD ports system.
gtkimageview port is currently without an official maintainer, and could 
use someone to help keep it up to date.

Duties, would pretty much be just submit pr's and patches, like you did 
above, but with a maintainer, these patches would get committer faster.  
If someone else sends in a pr, you would get an email, check the patch, 
and either reply back to approve it, or suggest a better patch.

Do you have any interest in being the official maintainer for this port?

-- 
Michael Scheidell, CTO
 >*| * SECNAP Network Security Corporation
d: +1.561.948.2259
w: http://people.freebsd.org/~scheidell
Comment 2 Bojan Petrovic 2012-04-28 10:56:37 UTC
> gtkimageview port is currently without an official maintainer, and
> could use someone to help keep it up to date.

Sure, I'd be glad to help. I started going through the "Contributing to
the FreeBSD Ports Collection" so that I can get acquainted with my
responsibilities.

Regards,
Bojan
Comment 3 Rodrigo OSORIO 2012-05-25 10:59:31 UTC
Michael, Borjan

Here is the Bojan fix with small changes.
Also bump the portrevision.

Thanks Bojan for you help.
- rodrigo
Comment 4 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-06-08 15:12:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rm

I will take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-06-11 09:00:33 UTC
rm          2012-06-11 08:00:16 UTC

  FreeBSD ports repository

  Modified files:
    graphics/ufraw       Makefile pkg-descr 
  Log:
  - fix build when WITH_GTK is disabled, but x11-toolkits/gtkimageview
    is installed
  
  I also added similar change for WITH_GIMP option, because configure tries to
  autodetect it too. PORTREVISION bump doesn't needed because GTK is enabled by
  default.
  
  PR:             166722
  Submitted by:   Bojan Petrovic <bojan_petrovic at fastmail dot fm>
  Approved by:    Rodrigo OSORIO <rodrigo at bebik dot net> (maintainer)
  
  Revision  Changes    Path
  1.55      +3 -0      ports/graphics/ufraw/Makefile
  1.5       +1 -1      ports/graphics/ufraw/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2012-06-11 09:04:25 UTC
State Changed
From-To: open->closed

Committed, thank you!