Bug 167385 - [patch] net/netatalk 2.2.2 insists on using sendfile
Summary: [patch] net/netatalk 2.2.2 insists on using sendfile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joe Marcus Clarke
Depends on:
Reported: 2012-04-28 08:10 UTC by Daniel Becker
Modified: 2012-04-29 01:50 UTC (History)
0 users

See Also:

file.diff (769 bytes, patch)
2012-04-28 08:10 UTC, Daniel Becker
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Becker 2012-04-28 08:10:07 UTC
After updating to version 2.2.2, Netatalk uses sendfile to transmit data to the client. As documented in kern/141305, this causes severe performance issues for Netatalk shares hosted on ZFS volumes, manifesting itself in extremely low network transfer speed, while causing excessive disk I/O.

Please consider exposing the --disable-sendfile configure switch introduced in Netatalk 2.2.2 through the port's config options.

Fix: Create a config option for disabling the use of sendfile. Patch attached.

Patch attached with submission follows:
How-To-Repeat: - create Netatalk share on ZFS
- read any files from the share
- watch transfer rate and server-side disk I/O
Comment 1 Edwin Groothuis freebsd_committer 2012-04-28 21:22:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Joe Marcus Clarke freebsd_committer 2012-04-29 01:43:43 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer 2012-04-29 01:43:47 UTC
marcus      2012-04-29 00:43:37 UTC

  FreeBSD ports repository

  Modified files:
    net/netatalk         Makefile 
  Disable sendfile support by default and make it optional.  Sendfile
  can cause performance and excessive I/O problems when used with ZFS.
  PR:             167385
  Submitted by:   Daniel Becker <razzfazz@gmail.com>
  Revision  Changes    Path
  1.106     +9 -1      ports/net/netatalk/Makefile
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"