Bug 168756 - net/boinc-client fix build for C programs and seti
Summary: net/boinc-client fix build for C programs and seti
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 14:30 UTC by Alexey Shuvaev
Modified: 2012-06-10 15:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.89 KB, patch)
2012-06-06 14:30 UTC, Alexey Shuvaev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shuvaev 2012-06-06 14:30:10 UTC
First, repair the brain damage of including C++ header inside pure C programs. Although the final linking stage has to be done with C++ linker anyway as boinc is written in C++, the compilation could be done with C compiler. Moreover, it is supported by the boinc_api.h with clean separation of C and C++ namespaces. This fix does not seem to affect anything, both boinc-client and setiathome compile cleanly (tested when both have WITHOUN_X11).

Second, in order to actually fix the build of C programs, the changeset 25543 from the upstream is also incorporated. Now I was able to compile C boinc application.

Third, if boinc-client is compiled WITHOUT_X11, the build for setiathome is broken, even if it is also configured WITHOUT_X11. It still needs reduce.h (see client/gdata.h at line 39 in setiathome sources). So, install it unconditionally in boinc-client. With this fix setiathome compiles cleanly too (WITHOUT_X11 is set in both boinc-client and setitahome).

P.S. I am currently working with Greg Childers from NFS@home to provide native FreeBSD applications, so these fixes are from the real life.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2012-06-06 23:14:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Pav Lucistnik freebsd_committer 2012-06-10 15:38:01 UTC
State Changed
From-To: open->closed

Committed, thanks! 

I'd love to see more native FreeBSD app on BOINC platform!
Comment 3 dfilter service freebsd_committer 2012-06-10 15:39:16 UTC
pav         2012-06-10 14:39:02 UTC

  FreeBSD ports repository

  Modified files:
    net/boinc-client     Makefile 
    net/boinc-client/files patch-api__boinc_api.h 
  Log:
  - Fix header files integrity when X11 option is disabled
  - Fix header files to allow pure C client app to be built
  - OPTIONSng
  
  PR:             ports/168714, ports/168756
  Submitted by:   Alexey Shuvaev <bugsbeastie@gmail.com>, Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
  
  Revision  Changes    Path
  1.55      +44 -40    ports/net/boinc-client/Makefile
  1.2       +17 -10    ports/net/boinc-client/files/patch-api__boinc_api.h
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"