Bug 168838 - sysutils/ldapvi: error: non-void function 'copy_sasl_output' should return a value [-Wreturn-type]
Summary: sysutils/ldapvi: error: non-void function 'copy_sasl_output' should return a ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sofian Brabez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-08 10:00 UTC by O. Hartmann
Modified: 2012-07-10 12:30 UTC (History)
0 users

See Also:

Attachments
file.diff (298 bytes, patch)
2012-06-08 10:00 UTC, O. Hartmann 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2012-06-08 10:00:27 UTC 
Port sysutils/ldapvi doesn't compile with CLANG and fails in source file "ldapvi.c", line 1468:


ldapvi.c:1468:30: error: non-void function 'copy_sasl_output' should return a value [-Wreturn-type]
        if (lstat(sasl, &st) == -1) return;

Fix: Make the if()-clause returning logically FALSE (or zero/0) after testing the condition. The function delivers the number of lines, as far as I can understand the code and a Zero value seems logically correct.

Patch attached with submission follows:
How-To-Repeat: Compile sysutils/ldapvi with CLANG 3.1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-08 20:31:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sbz

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-07-10 12:23:08 UTC 
sbz         2012-07-10 11:22:59 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/ldapvi      Makefile 
  Added files:
    sysutils/ldapvi/files patch-ldapvi.c 
  Log:
  - Fix build with clang [1]
  - Add LICENSE
  - Make portlint happy
  
  PR:             ports/168838
  Submitted by:   Oliver Hartmann <ohartman at zedat.fu-berlin.de> [1]
  Approved by:    myself (maintainer)
  
  Revision  Changes    Path
  1.11      +9 -7      ports/sysutils/ldapvi/Makefile
  1.1       +11 -0     ports/sysutils/ldapvi/files/patch-ldapvi.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Sofian Brabez freebsd_committer freebsd_triage 2012-07-10 12:23:29 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!