Bug 168871 - graphics/ImageMagick does not pass bundled self-tests unless built with "--enable-hdri"
graphics/ImageMagick does not pass bundled self-tests unless built with "--en...
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Martin Matuska
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-09 01:10 UTC by sol
Modified: 2012-06-09 20:26 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sol 2012-06-09 01:10:11 UTC
	ImageMagick builds, but fails 3 self-tests:
[...]
make  check-TESTS check-local
[...]
PASS: tests/validate-stream.sh
FAIL: tests/validate-formats-in-memory.sh
FAIL: tests/validate-formats-on-disk.sh
PASS: Magick++/tests/exceptions.sh
[...]
PASS: Magick++/tests/readWriteImages.sh
FAIL: Magick++/demo/analyze.sh
PASS: Magick++/demo/button.sh
[...]
PASS: wand/wandtest.sh
===========================================
3 of 49 tests failed	# sometimes "2 of 49 tests failed"
See ./test-suite.log
Please report to http://www.imagemagick.org
===========================================
*** Error code 1
[...]

# less ./work/ImageMagick-6.7.7-0/test-suite.log
[...]
FAIL: tests/validate-formats-in-memory.sh (exit: 1)
===================================================

Version: ImageMagick 6.7.7-0 2012-06-05 Q16 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2012 ImageMagick Studio LLC

ImageMagick Validation Suite (FormatsInMemory)

validate image formats in memory:
  test 0: ART/Undefined/TrueColor/8-bits... pass.
  test 1: ART/Undefined/TrueColorAlpha/8-bits... pass.
  test 2: ART/Undefined/Grayscale/8-bits... pass.
  test 3: ART/Undefined/GrayscaleAlpha/8-bits... pass.
[...]
  test 847: AI/Undefined/Grayscale/8-bits... fail (with distortion 5.31785e-08).
  test 848: AI/Undefined/GrayscaleAlpha/8-bits... fail (with distortion 5.31785e-08).
  test 849: AI/Undefined/Palette/8-bits... pass.
  test 850: AI/Undefined/PaletteAlpha/8-bits... pass.
  test 851: AI/Undefined/PaletteBilevelAlpha/8-bits... pass.
  test 852: AI/Undefined/Bilevel/1-bits... pass.
  test 853: AI/Undefined/ColorSeparation/8-bits... pass.
  test 854: AI/Undefined/ColorSeparationAlpha/8-bits... pass.
  test 855: AI/Undefined/TrueColor/10-bits... pass.
  test 856: AI/Undefined/TrueColor/12-bits... pass.
  test 857: AI/Undefined/TrueColor/16-bits... pass.
  test 858: EPDF/Undefined/TrueColor/8-bits... pass.
  test 859: EPDF/Undefined/TrueColorAlpha/8-bits... pass.
  test 860: EPDF/Undefined/Grayscale/8-bits... fail (with distortion 5.31785e-08).
  test 861: EPDF/Undefined/GrayscaleAlpha/8-bits... fail (with distortion 5.31785e-08).
  test 862: EPDF/Undefined/Palette/8-bits... pass.
[...]
(there are more failed test cases in PDF/*, same distortion value)

Fix: 

In graphics/ImageMagick/Makefile:

-#.if defined(WITH_IMAGEMAGICK_HDRI)
+.if defined(WITH_IMAGEMAGICK_HDRI)
-#BROKEN=                        hdri support broken, disable in options
-#CONFIGURE_ARGS+=       --enable-hdri
+#CONFIGURE_ARGS+=       --enable-hdri
-#_NO_IMAGEMAGICK_TESTS=yes
-#.else
+.else
CONFIGURE_ARGS+=        --disable-hdri
-#.endif
+.endif

Also, add config option for IMAGEMAGICK_HDRI ("on" by default).
How-To-Repeat: 
	Config options as above, IMAGEMAGICK_TESTS turned on:
	 `cd $PORTSDIR/graphics/ImageMagick && make install clean`
Comment 1 Martin Wilke freebsd_committer 2012-06-09 08:27:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mm

over to maintainer
Comment 2 dfilter freebsd_committer 2012-06-09 19:06:37 UTC
mm          2012-06-09 18:06:28 UTC

  FreeBSD ports repository

  Modified files:
    graphics/ImageMagick Makefile distinfo pkg-plist 
  Log:
  Update to 6.7.7-6
  Re-enable WITH_IMAGEMAGICK_HDRI [1]
  
  PR:             ports/168871 [1]
  Submitted by:   sol@triumf.ca [1]
  
  Revision  Changes    Path
  1.348     +6 -8      ports/graphics/ImageMagick/Makefile
  1.168     +2 -2      ports/graphics/ImageMagick/distinfo
  1.148     +0 -1      ports/graphics/ImageMagick/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Matuska freebsd_committer 2012-06-09 20:25:59 UTC
State Changed
From-To: open->closed

Resolved. Thanks!