Just the other day, while showing a younger colleague his way around the FreeBSD source tree, I wanted to show him the cool "die_you_gravy_sucking_pig_dog" funtion, as an example how coding can be fun. Regretfully I found this function is no longer in the shutdown.c source. It has apparently been removed in an otherwise very unsubstantial commit (Revision 1.30, Tue Dec 29 08:49:43 2009) I don't think the function name was moronic. It's historic and deserves to be in the source tree. Therefore I propose to return to the original funtion name, keeping the funtional changes (void) made in that commit. Fix: patch attached Patch attached with submission follows: How-To-Repeat: 1) have a little sense of humor 2) read shutdown.c before Tue Dec 29 08:49:43 2009 3) read shutdown.c after Tue Dec 29 08:49:43 2009
While it is true that the original function name goes back to BSD (and predates FreeBSD), I'm not sure it is worth renaming it back. -- John Baldwin
Responsible Changed From-To: freebsd-advocacy->freebsd-bugs Not an advocacy PR.
Author: des Date: Wed Aug 1 09:10:21 2012 New Revision: 238968 URL: http://svn.freebsd.org/changeset/base/238968 Log: Restore a piece of BSD history. PR: 169127 Submitted by: Ruben de Groot <ruben@hacktor.com> MFC after: 1 week Modified: head/sbin/shutdown/shutdown.c Modified: head/sbin/shutdown/shutdown.c ============================================================================== --- head/sbin/shutdown/shutdown.c Wed Aug 1 09:00:26 2012 (r238967) +++ head/sbin/shutdown/shutdown.c Wed Aug 1 09:10:21 2012 (r238968) @@ -93,7 +93,7 @@ static char mbuf[BUFSIZ]; static const char *nosync, *whom; static void badtime(void); -static void perform_shutdown(void); +static void die_you_gravy_sucking_pig_dog(void); static void finish(int); static void getoffset(char *); static void loop(void); @@ -282,7 +282,7 @@ loop(void) if (!tp->timeleft) break; } - perform_shutdown(); + die_you_gravy_sucking_pig_dog(); } static jmp_buf alarmbuf; @@ -349,7 +349,7 @@ timeout(int signo __unused) } static void -perform_shutdown(void) +die_you_gravy_sucking_pig_dog(void) { char *empty_environ[] = { NULL }; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks!