Bug 169220 - [PATCH] sysutils/cciss_vol_status: fix usage of ${SRC_BASE} before it is defined
Summary: [PATCH] sysutils/cciss_vol_status: fix usage of ${SRC_BASE} before it is defined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 00:40 UTC by Jason Helfman
Modified: 2012-07-01 23:58 UTC (History)
1 user (show)

See Also:


Attachments
cciss_vol_status-1.09.patch (572 bytes, patch)
2012-06-19 00:40 UTC, Jason Helfman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Helfman freebsd_committer 2012-06-19 00:40:22 UTC
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

Port maintainer (mm@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer 2012-06-19 00:41:44 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jason Helfman freebsd_committer 2012-07-01 07:34:42 UTC
Responsible Changed
From-To: mm->jgh

maintainer timeout (14 days)
Comment 3 dfilter service freebsd_committer 2012-07-01 23:36:55 UTC
jgh         2012-07-01 22:36:46 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/cciss_vol_status Makefile 
  Log:
  - include bsd.port.pre.mk so SRC_BASE is defined before referenced, and include bsd.port.post.mk
  
  PR:     ports/169220
  Submitted by:   jgh@
  Approved by:    maintainer timeout ( 14 days )
  
  Revision  Changes    Path
  1.8       +3 -1      ports/sysutils/cciss_vol_status/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Jason Helfman freebsd_committer 2012-07-01 23:58:25 UTC
State Changed
From-To: open->closed

Committed. Thanks!