Bug 169569 - [patch] port editors/mousepad search tool only works once
Summary: [patch] port editors/mousepad search tool only works once
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Olivier Duchateau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-01 04:40 UTC by Filipy Galiza Soares
Modified: 2012-07-17 22:10 UTC (History)
0 users

See Also:


Attachments
file.txt (1.13 KB, text/plain)
2012-07-01 04:40 UTC, Filipy Galiza Soares
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Filipy Galiza Soares 2012-07-01 04:40:09 UTC
I've recently made a fresh install of the FreeBSD 9.0 Release, and together, the XFCE 4.10 desktop with the mousepad editor.

Using the mousepad editor to edit some code, I used the search tool once, found what I wanted for the moment... needed again, I tried use the tool, but now the search button looks inactive and the search function doesn't work.

Searching, I found this: https://bugs.archlinux.org/task/17017 that reports the same problem. And after here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549334

Fix: As suggested here (https://bugs.archlinux.org/task/17017), apply this patch (http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=15;filename=00_resensitize-find-button.patch;att=1;bug=549334) solves the problem.

I made a little modification to that patch works well with the editors/mousepad port.

You just need to make directory '/usr/ports/editors/mousepad/files'; copy the patch to there (;remove the ".txt" from the end of file) and recompile the port (again). Since 'mousepad' is already installed, I removed (make deinstall) and installed the new (compiled) version (I did 'make install clean').

Right now, everything working fine.



Patch attached with submission follows:
How-To-Repeat: You just need to have ports and system up to date (and mousepad installed).

Open 'mousepad'; use the search tool; close search tool; try use search tool again and the search button appears as inactive.
Comment 1 Edwin Groothuis freebsd_committer 2012-07-01 04:40:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-xfce

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Olivier Duchateau freebsd_committer 2012-07-01 08:53:17 UTC
Responsible Changed
From-To: freebsd-xfce->olivierd

I'll take it.
Comment 3 dfilter service freebsd_committer 2012-07-17 22:04:41 UTC
Author: olivierd
Date: Tue Jul 17 21:04:27 2012
New Revision: 301040
URL: http://svn.freebsd.org/changeset/ports/301040

Log:
  Fix search tool
  
  PR:	169569
  Submitted by:	Filipy Galiza Soares <65@filipy.com>
  Approved by:	miwi, rene (mentors)

Added:
  head/editors/mousepad/files/
  head/editors/mousepad/files/patch-src_search.c   (contents, props changed)
Modified:
  head/editors/mousepad/Makefile

Modified: head/editors/mousepad/Makefile
==============================================================================
--- head/editors/mousepad/Makefile	Tue Jul 17 20:57:14 2012	(r301039)
+++ head/editors/mousepad/Makefile	Tue Jul 17 21:04:27 2012	(r301040)
@@ -7,7 +7,7 @@
 
 PORTNAME=	mousepad
 PORTVERSION=	0.2.16
-PORTREVISION=	10
+PORTREVISION=	11
 CATEGORIES=	editors xfce
 MASTER_SITES=	${MASTER_SITE_XFCE}
 MASTER_SITE_SUBDIR=src/apps/${PORTNAME}/${PORTVERSION:R}

Added: head/editors/mousepad/files/patch-src_search.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/editors/mousepad/files/patch-src_search.c	Tue Jul 17 21:04:27 2012	(r301040)
@@ -0,0 +1,28 @@
+--- src/search.c.orig
++++ src/search.c
+@@ -210,8 +210,11 @@
+ 		G_CALLBACK(toggle_sensitivity), NULL);
+ 	 g_signal_connect(G_OBJECT(entry_find), "delete-text",
+ 		G_CALLBACK(toggle_sensitivity), NULL);
+-	 if (sd->search.string_find) 
++	 if (sd->search.string_find) {
+ 		 gtk_entry_set_text(GTK_ENTRY(entry_find), sd->search.string_find);
++		 gtk_dialog_set_response_sensitive(GTK_DIALOG(dialog),
++			GTK_RESPONSE_OK, TRUE);
++	 }
+ 
+ 	gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_OK);
+ 	gtk_entry_set_activates_default(GTK_ENTRY(entry_find), TRUE);
+@@ -275,8 +278,11 @@
+ 		G_CALLBACK(toggle_sensitivity), NULL);
+ 	 g_signal_connect(G_OBJECT(entry_find), "delete-text",
+ 		G_CALLBACK(toggle_sensitivity), NULL);
+-	 if (sd->search.string_find) 
++	 if (sd->search.string_find) {
+ 		 gtk_entry_set_text(GTK_ENTRY(entry_find), sd->search.string_find);
++		 gtk_dialog_set_response_sensitive(GTK_DIALOG(dialog),
++			GTK_RESPONSE_OK, TRUE);
++	}
+ 	label_replace = gtk_label_new_with_mnemonic(_("Re_place with: "));
+ 	 gtk_misc_set_alignment(GTK_MISC(label_replace), 0, 0.5);
+ 	 gtk_table_attach_defaults(GTK_TABLE(table), label_replace, 0, 1, 1, 2);
\ No newline at end of file
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Olivier Duchateau freebsd_committer 2012-07-17 22:08:17 UTC
State Changed
From-To: open->closed

Committed. Thanks!