Bug 169788 - [PATCH] x11/terminator: use new options framework
[PATCH] x11/terminator: use new options framework
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: jgh@FreeBSD.org
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-11 18:50 UTC by jgh@FreeBSD.org
Modified: 2012-07-24 08:10 UTC (History)
1 user (show)

See Also:


Attachments
terminator-0.96_3.patch (949 bytes, patch)
2012-07-11 18:50 UTC, jgh@FreeBSD.org
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jgh@FreeBSD.org freebsd_committer 2012-07-11 18:50:01 UTC
use new options framework

Port maintainer (tom@hur.st) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer 2012-07-11 18:50:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2012-07-11 18:50:15 UTC
Maintainer of x11/terminator,

Please note that PR ports/169788 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169788

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2012-07-11 18:50:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 jgh@FreeBSD.org freebsd_committer 2012-07-24 05:18:43 UTC
State Changed
From-To: feedback->open

maintainer timeout, 14 days
Comment 5 dfilter freebsd_committer 2012-07-24 08:01:25 UTC
Author: jgh
Date: Tue Jul 24 07:01:12 2012
New Revision: 301440
URL: http://svn.freebsd.org/changeset/ports/301440

Log:
  - adopt optionsNG
  
  PR:	ports/169788
  Submitted by:	jgh@ (myself)
  Approved by:	maintainer timeout, tom@hur.st ( 14 days )

Modified:
  head/x11/terminator/Makefile   (contents, props changed)

Modified: head/x11/terminator/Makefile
==============================================================================
--- head/x11/terminator/Makefile	Tue Jul 24 05:06:43 2012	(r301439)
+++ head/x11/terminator/Makefile	Tue Jul 24 07:01:12 2012	(r301440)
@@ -17,8 +17,9 @@ COMMENT=	Multiple GNOME terminals in one
 
 LICENSE=	GPLv2
 
-OPTIONS=	NLS	"Native language support" 	on \
-		GCONF	"Use GNOME Terminal settings"	on
+OPTIONS_DEFINE=	NLS GCONF
+GCONF_DESC=	Use GNOME Terminal settings
+OPTIONS_DEFAULT=	NLS GCONF
 
 USE_PYTHON=	2.5+
 USE_PYDISTUTILS=	yes
@@ -31,7 +32,7 @@ WANT_GNOME=	yes
 .include <bsd.port.pre.mk>
 
 PYSETUP+=	--without-icon-cache
-.ifdef(WITHOUT_NLS)
+.if empty(PORT_OPTIONS:MNLS)
 PLIST_SUB+=	NLS="@comment "
 PYSETUP+=	--without-gettext
 .else
@@ -40,7 +41,7 @@ PLIST_SUB+=	NLS=""
 .endif
 
 RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/gtk-2.0/vtemodule.so:${PORTSDIR}/x11-toolkits/py-vte
-.if defined(WITH_GCONF)
+.if ${PORT_OPTIONS:MGCONF}
 USE_GNOME+=	pygnome2
 .endif
 USE_GNOME+=	pygtk2
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 jgh@FreeBSD.org freebsd_committer 2012-07-24 08:01:30 UTC
State Changed
From-To: open->closed

Committed. Thanks!