multimedia/libdvdread ignores WITH_DEBUG just like multimedia/libdvdnav does (ports/169698). The attached patch fixes this. I didn't bump PORTREVISION as the default packages shouldn't be affected. The crash I was investigating turned out to be caused by what I consider a libdvdread API violation in dvdbackup, thus there's no patch for this issue in this PR. I'll submit the fix for dvdbackup once I discussed this with the upstream. Fix: A fix is attached. Patch attached with submission follows: How-To-Repeat: 1. Build with WITH_DEBUG. 2. Try to debug a crash in libdvdread with gdb. 3. Make a sad face after realizing that there are no symbols.
Responsible Changed From-To: freebsd-ports-bugs->martymac Over to maintainer (via the GNATS Auto Assign Tool)
Author: martymac Date: Wed Aug 1 12:17:42 2012 New Revision: 301824 URL: http://svn.freebsd.org/changeset/ports/301824 Log: Add DEBUG option PR: ports/169844 Submitted by: Fabian Keil <fk@fabiankeil.de> Modified: head/multimedia/libdvdread/Makefile Modified: head/multimedia/libdvdread/Makefile ============================================================================== --- head/multimedia/libdvdread/Makefile Wed Aug 1 12:10:40 2012 (r301823) +++ head/multimedia/libdvdread/Makefile Wed Aug 1 12:17:42 2012 (r301824) @@ -7,7 +7,7 @@ PORTNAME= libdvdread PORTVERSION= 4.2.0 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= multimedia # Svn repository URL : svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdread MASTER_SITES= http://dvdnav.mplayerhq.hu/releases/ \ @@ -28,12 +28,11 @@ CONFIGURE_ARGS= --prefix="${PREFIX}" \ --shlibdir="${PREFIX}/lib" \ --incdir="${PREFIX}/include/dvdread" \ --disable-opts \ - --disable-debug \ --cc="${CC}" USE_GMAKE= yes USE_LDCONFIG= yes -OPTIONS_DEFINE= DVDCSS +OPTIONS_DEFINE= DVDCSS DEBUG .if !defined(PACKAGE_BUILDING) OPTIONS_DEFAULT= DVDCSS .endif @@ -47,6 +46,12 @@ DVDCSS_LIBVERSION= 3 LIB_DEPENDS+= dvdcss:${PORTSDIR}/multimedia/libdvdcss .endif +.if ${PORT_OPTIONS:MDEBUG} +CONFIGURE_ARGS+= --enable-debug --disable-strip +.else +CONFIGURE_ARGS+= --disable-debug +.endif + post-patch: @${REINPLACE_CMD} -e 's|-ldl ||g' \ ${WRKSRC}/Makefile _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed with minor changes, thanks!