Bug 169844 - multimedia/libdvdread 4.2.0 ignores WITH_DEBUG
Summary: multimedia/libdvdread 4.2.0 ignores WITH_DEBUG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ganael LAPLANCHE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-14 09:10 UTC by Fabian Keil
Modified: 2012-08-01 13:44 UTC (History)
0 users

See Also:


Attachments
file.diff (567 bytes, patch)
2012-07-14 09:10 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2012-07-14 09:10:01 UTC
multimedia/libdvdread ignores WITH_DEBUG just like multimedia/libdvdnav does (ports/169698). The attached patch fixes this.

I didn't bump PORTREVISION as the default packages shouldn't be affected.

The crash I was investigating turned out to be caused by what I consider a libdvdread API violation in dvdbackup, thus there's no patch for this issue in this PR. I'll submit the fix for dvdbackup once I discussed this with the upstream.

Fix: A fix is attached.

Patch attached with submission follows:
How-To-Repeat: 1. Build with WITH_DEBUG.
2. Try to debug a crash in libdvdread with gdb.
3. Make a sad face after realizing that there are no symbols.
Comment 1 Edwin Groothuis freebsd_committer 2012-07-14 09:10:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->martymac

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2012-08-01 13:17:57 UTC
Author: martymac
Date: Wed Aug  1 12:17:42 2012
New Revision: 301824
URL: http://svn.freebsd.org/changeset/ports/301824

Log:
  Add DEBUG option
  
  PR:		ports/169844
  Submitted by:	Fabian Keil <fk@fabiankeil.de>

Modified:
  head/multimedia/libdvdread/Makefile

Modified: head/multimedia/libdvdread/Makefile
==============================================================================
--- head/multimedia/libdvdread/Makefile	Wed Aug  1 12:10:40 2012	(r301823)
+++ head/multimedia/libdvdread/Makefile	Wed Aug  1 12:17:42 2012	(r301824)
@@ -7,7 +7,7 @@
 
 PORTNAME=	libdvdread
 PORTVERSION=	4.2.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	multimedia
 # Svn repository URL : svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdread
 MASTER_SITES=	http://dvdnav.mplayerhq.hu/releases/ \
@@ -28,12 +28,11 @@ CONFIGURE_ARGS=	--prefix="${PREFIX}" \
 		--shlibdir="${PREFIX}/lib" \
 		--incdir="${PREFIX}/include/dvdread" \
 		--disable-opts \
-		--disable-debug \
 		--cc="${CC}"
 USE_GMAKE=	yes
 USE_LDCONFIG=	yes
 
-OPTIONS_DEFINE=	DVDCSS
+OPTIONS_DEFINE=	DVDCSS DEBUG
 .if !defined(PACKAGE_BUILDING)
 OPTIONS_DEFAULT=	DVDCSS
 .endif
@@ -47,6 +46,12 @@ DVDCSS_LIBVERSION=	3
 LIB_DEPENDS+=	dvdcss:${PORTSDIR}/multimedia/libdvdcss
 .endif
 
+.if ${PORT_OPTIONS:MDEBUG}
+CONFIGURE_ARGS+=	--enable-debug --disable-strip
+.else
+CONFIGURE_ARGS+=	--disable-debug
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|-ldl ||g' \
 		${WRKSRC}/Makefile
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Ganael LAPLANCHE freebsd_committer 2012-08-01 13:44:02 UTC
State Changed
From-To: open->closed

Committed with minor changes, thanks!