Bug 170215 - [build] cd release; make cdrom should fail if not executed using new process
Summary: [build] cd release; make cdrom should fail if not executed using new process
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 9.0-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 17:00 UTC by Enji Cooper
Modified: 2018-01-03 05:16 UTC (History)
0 users

See Also:


Attachments
release-Makefile.diff.txt (437 bytes, text/plain; charset=us-ascii)
2012-07-27 22:03 UTC, Glen Barber
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer 2012-07-27 17:00:18 UTC
More than a handful of people have lost a few hours time trying to create CD ISOs because they're using the old method of doing the release process (one example is: [1]).

1. http://lists.freebsd.org/pipermail/freebsd-current/2011-June/025326.html

How-To-Repeat: cd release; make cdrom
Comment 1 Glen Barber freebsd_committer 2012-07-27 22:03:31 UTC
On Fri, Jul 27, 2012 at 03:53:47PM +0000, Garrett Cooper wrote:
> 1. http://lists.freebsd.org/pipermail/freebsd-current/2011-June/025326.html
> >How-To-Repeat:
> cd release; make cdrom

I think I see the problem.

Can you see if the attached patch fixes the problem for you?

Regards,

Glen
Comment 2 Glen Barber freebsd_committer 2012-07-27 22:12:02 UTC
State Changed
From-To: open->feedback

Feedback requested. 



Comment 3 Glen Barber freebsd_committer 2012-07-27 22:12:02 UTC
Responsible Changed
From-To: freebsd-bugs->gjb

I'll take it.
Comment 4 Enji Cooper freebsd_committer 2012-07-28 22:03:43 UTC
On Fri, Jul 27, 2012 at 2:03 PM, Glen Barber <gjb@freebsd.org> wrote:
> On Fri, Jul 27, 2012 at 03:53:47PM +0000, Garrett Cooper wrote:
>> 1. http://lists.freebsd.org/pipermail/freebsd-current/2011-June/025326.html
>> >How-To-Repeat:
>> cd release; make cdrom
>
> I think I see the problem.
>
> Can you see if the attached patch fixes the problem for you?

This will remove the release directory from install media which might
be undesirable.

My guess (and it's just a guess right now) is that it's a variable
that's being passed on the command line that's being appended to,
instead of it being passed in the environment (example: see
MAKEOBJDIRPREFIX in src/Makefile). Which is why I wanted the exact
command -- do determine whether or not it was that class of user error
that wasn't being properly handled.

Thanks,
-Garrett
Comment 5 Alexander Pyhalov 2012-07-30 07:18:01 UTC
Hello.
I've just made:

make toolchain
make -DNO_CLEAN buildkernel
make -DNO_CLEAN buildworld
cd release
make cdrom

I made it on

FreeBSD XX 8.3-RELEASE FreeBSD 8.3-RELEASE #2 r234443: Thu Apr 19 
10:24:05 MSK 2012     alp@XX:/usr/obj/usr/src/sys/MyKern  amd64

if it matters.

On 07/29/2012 01:03, Garrett Cooper wrote:
> nd it's just a guess right now) is that it's a variable
> that's being passed on the command line that's being appended to,
> instead of it being passed in the environment (example: see
> MAKEOBJDIRPREFIX in src/Makefile). Which is why I wanted the exact
> command -- do determine whether or not it was that class of user error
> that wasn't being properly handled.


-- 
Best regards,
Alexander Pyhalov,
system administrator of Computer Center of Southern Federal University
Comment 6 Glen Barber freebsd_committer 2012-07-30 08:05:16 UTC
Responsible Changed
From-To: gjb->freebsd-bugs

Back to the pool.
Comment 7 Glen Barber freebsd_committer 2012-07-30 08:55:02 UTC
On Sat, Jul 28, 2012 at 02:03:43PM -0700, Garrett Cooper wrote:
> On Fri, Jul 27, 2012 at 2:03 PM, Glen Barber <gjb@freebsd.org> wrote:
> > On Fri, Jul 27, 2012 at 03:53:47PM +0000, Garrett Cooper wrote:
> >> 1. http://lists.freebsd.org/pipermail/freebsd-current/2011-June/025326.html
> >> >How-To-Repeat:
> >> cd release; make cdrom
> >
> > I think I see the problem.
> >
> > Can you see if the attached patch fixes the problem for you?
> 
> This will remove the release directory from install media which might
> be undesirable.
> 


No, this will remove the /usr/obj/usr/src/release directory, which is
where the packaging of the distribution files takes place.

Glen
Comment 8 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:59:08 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped