Bug 170669 - [patch] devel/subversion: fix build when WITHOUT_NLS and WITH_KDE_KWALLET are defined
Summary: [patch] devel/subversion: fix build when WITHOUT_NLS and WITH_KDE_KWALLET are...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alberto Villa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 15:20 UTC by Alberto Villa
Modified: 2012-08-31 09:10 UTC (History)
0 users

See Also:

Attachments
file.diff (429 bytes, patch)
2012-08-16 15:20 UTC, Alberto Villa 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Villa freebsd_committer freebsd_triage 2012-08-16 15:20:06 UTC 
`make configure` fails in devel/subversion when WITHOUT_NLS and WITH_KDE_KWALLET are defined, with:

checking whether to look for KWallet... yes
configure: error: missing support for internationalization
===>  Script "configure" failed unexpectedly.

kwallet.m4 reveals that NLS support is required by KWallet.

Fix: The attached patch forces NLS support to be built also when WITH_KDE_KWALLET is defined.

Patch attached with submission follows:
How-To-Repeat: make configure -C /usr/ports/devel/subversion -DWITHOUT_NLS -DWITH_KDE_KWALLET
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-16 15:20:16 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lev

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alberto Villa freebsd_committer freebsd_triage 2012-08-31 09:02:06 UTC 
Responsible Changed
From-To: lev->avilla

I'll take it (maintainer timeout: 2 weeks).
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-08-31 09:04:13 UTC 
Author: avilla
Date: Fri Aug 31 08:03:59 2012
New Revision: 303399
URL: http://svn.freebsd.org/changeset/ports/303399

Log:
  - Fix build when WITHOUT_NLS and WITH_KDE_KWALLET are defined together.
  
  PR:		170669
  Submitted by:	avilla (me)
  Approved by:	lev (maintainer timeout: 2 weeks)

Modified:
  head/devel/subversion/Makefile.common   (contents, props changed)

Modified: head/devel/subversion/Makefile.common
==============================================================================
--- head/devel/subversion/Makefile.common	Fri Aug 31 06:09:26 2012	(r303398)
+++ head/devel/subversion/Makefile.common	Fri Aug 31 08:03:59 2012	(r303399)
@@ -130,7 +130,8 @@ PLIST_SUB+=	SERF="@comment "
 LIB_DEPENDS+=	svn_client-1:${PORTSDIR}/devel/subversion
 .endif
 
-.if !defined(WITHOUT_NLS)
+# KWallet requires NLS to be enabled.
+.if !defined(WITHOUT_NLS) || defined(WITH_KDE_KWALLET)
 USE_GETTEXT=	yes
 PLIST_SUB+=	WITHOUT_GETTEXT=""
 .else
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Alberto Villa freebsd_committer freebsd_triage 2012-08-31 09:04:25 UTC 
State Changed
From-To: open->closed

Fix committed.