Bug 170670 - [maintainer-update] update converters/bsdconv to 7.5
Summary: [maintainer-update] update converters/bsdconv to 7.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Frederic Culot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 16:00 UTC by buganini
Modified: 2012-08-16 20:00 UTC (History)
0 users

See Also:


Attachments
file.diff (2.10 KB, patch)
2012-08-16 16:00 UTC, buganini
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description buganini 2012-08-16 16:00:20 UTC
Update converters/bsdconv to 7.5
Switch to optionsNG

Changelog:
        add {from,to}/CP1253
        fix several linux issues
        bugfixes

http://redports.org/buildarchive/20120816144243-64733/

Fix: Patch attached with submission follows:
Comment 1 Frederic Culot freebsd_committer 2012-08-16 16:46:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->culot

I'll take it.
Comment 2 Frederic Culot freebsd_committer 2012-08-16 18:15:01 UTC
Hi Kuan-Chung,

thanks for submitting this update, however I have issues with the patch
you submitted.
Indeed, the patch applies fine but when I try to build the port either
locally or on redports, I got issues with bsdconv's Makefile. See for
instance the following log:

https://redports.org/~culot/20120816161610-7399-49845/bsdconv-7.5.log

Could you please have a look at it?

Thanks,
Frederic (culot@)
Comment 3 buganini 2012-08-16 18:30:00 UTC
Sorry,
missed a patch
http://www.cnmc.tw/~buganini/bsdconv-7.5.patch.txt

2012/8/16  <FreeBSD-gnats-submit@freebsd.org>:
> Thank you very much for your problem report.
> It has the internal identification `ports/170670'.
> The individual assigned to look at your
> report is: freebsd-ports-bugs.
>
> You can access the state of your problem report at any time
> via this link:
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=170670
>
>>Category:       ports
>>Responsible:    freebsd-ports-bugs
>>Synopsis:       [maintainer-update] update converters/bsdconv to 7.5
>>Arrival-Date:   Thu Aug 16 15:00:20 UTC 2012
Comment 4 dfilter service freebsd_committer 2012-08-16 19:52:14 UTC
Author: culot
Date: Thu Aug 16 18:52:02 2012
New Revision: 302653
URL: http://svn.freebsd.org/changeset/ports/302653

Log:
  - Update to 7.5
  
  Changes:	https://github.com/buganini/bsdconv/blob/master/Changelog
  PR:		ports/170670
  Submitted by: 	Kuan-Chung Chiu <buganini@gmail.com> (maintainer)

Added:
  head/converters/bsdconv/files/
  head/converters/bsdconv/files/patch-Makefile   (contents, props changed)
Modified:
  head/converters/bsdconv/Makefile
  head/converters/bsdconv/distinfo
  head/converters/bsdconv/pkg-plist

Modified: head/converters/bsdconv/Makefile
==============================================================================
--- head/converters/bsdconv/Makefile	Thu Aug 16 17:51:49 2012	(r302652)
+++ head/converters/bsdconv/Makefile	Thu Aug 16 18:52:02 2012	(r302653)
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	bsdconv
-PORTVERSION=	7.3
+PORTVERSION=	7.5
 CATEGORIES=	converters
 MASTER_SITES=	https://github.com/buganini/${PORTNAME}/tarball/${PORTVERSION}/
 DISTNAME=	buganini-${PORTNAME}-${PORTVERSION}-0-g${GITVERSION}
@@ -16,11 +16,12 @@ COMMENT=	BSD licensed charset/encoding c
 
 LICENSE=	BSD
 
-GITVERSION=	500f86a
+GITVERSION=	cf1989b
 FETCH_ARGS=	-pRr
 WRKSRC=		${WRKDIR}/buganini-${PORTNAME}-${GITVERSION}
 
-OPTIONS=	EXTRA "Extra codecs (Chinese specifics)" off
+OPTIONS_DEFINE=	EXTRA
+EXTRA_DESC=	Extra codecs (Chinese specifics)
 
 USE_LDCONFIG=	yes
 
@@ -31,7 +32,7 @@ INSTALL_TARGET=	installdir install_main 
 
 .include <bsd.port.options.mk>
 
-.if defined(WITH_EXTRA)
+.if ${PORT_OPTIONS:MEXTRA}
 ALL_TARGET+=	codecs_extra
 INSTALL_TARGET+=install_extra
 PLIST_SUB+=	EXTRA=""

Modified: head/converters/bsdconv/distinfo
==============================================================================
--- head/converters/bsdconv/distinfo	Thu Aug 16 17:51:49 2012	(r302652)
+++ head/converters/bsdconv/distinfo	Thu Aug 16 18:52:02 2012	(r302653)
@@ -1,2 +1,2 @@
-SHA256 (buganini-bsdconv-7.3-0-g500f86a.tar.gz) = 5336501a41946472249afe8492d51c3148ba0cd73fa6f883e93da409409238d6
-SIZE (buganini-bsdconv-7.3-0-g500f86a.tar.gz) = 4828689
+SHA256 (buganini-bsdconv-7.5-0-gcf1989b.tar.gz) = b056fbd1cdddb3d021b3331a1f89bae1bfc5783d8971721cc2267724bbf5db06
+SIZE (buganini-bsdconv-7.5-0-gcf1989b.tar.gz) = 4630675

Added: head/converters/bsdconv/files/patch-Makefile
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/converters/bsdconv/files/patch-Makefile	Thu Aug 16 18:52:02 2012	(r302653)
@@ -0,0 +1,20 @@
+--- Makefile.orig	2012-08-16 22:36:27.000000000 +0800
++++ Makefile	2012-08-16 22:36:47.000000000 +0800
+@@ -3,17 +3,9 @@
+ CFLAGS+=-Wall -DPREFIX='"${PREFIX}"' -DBSDCONV_PATH='"${BSDCONV_PATH}"'
+ SHLIBVER=7
+ 
+-UNAME_S=$(shell uname -s)
+-ifeq (${UNAME_S}, Darwin)
+-SHLIBNAME=libbsdconv.so
+-else
+ SHLIBNAME=libbsdconv.so.${SHLIBVER}
+-endif
+ 
+ LIBS?=
+-ifeq (${UNAME_S}, Linux)
+-LIBS+=-ldl
+-endif
+ 
+ TODO_CODECS_BASIC_TABLE=
+ TODO_CODECS_BASIC_TABLE+=from/3F

Modified: head/converters/bsdconv/pkg-plist
==============================================================================
--- head/converters/bsdconv/pkg-plist	Thu Aug 16 17:51:49 2012	(r302652)
+++ head/converters/bsdconv/pkg-plist	Thu Aug 16 18:52:02 2012	(r302653)
@@ -35,6 +35,7 @@ lib/libbsdconv.so.7
 %%DATADIR%%/from/UTF-32LE.so
 %%DATADIR%%/from/_CP1251
 %%DATADIR%%/from/_CP1252
+%%DATADIR%%/from/_CP1253
 %%DATADIR%%/from/_CP874
 %%DATADIR%%/from/_CP949
 %%DATADIR%%/from/_GB18030
@@ -139,6 +140,7 @@ lib/libbsdconv.so.7
 %%DATADIR%%/to/UTF-32LE.so
 %%DATADIR%%/to/_CP1251
 %%DATADIR%%/to/_CP1252
+%%DATADIR%%/to/_CP1253
 %%DATADIR%%/to/_CP874
 %%DATADIR%%/to/_CP936
 %%DATADIR%%/to/_CP949
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Frederic Culot freebsd_committer 2012-08-16 19:54:28 UTC
State Changed
From-To: open->closed

Committed. Thanks!