Bug 170724 - [MAINTAINER] games/connectagram: Makefile changed, Port require always DATA
Summary: [MAINTAINER] games/connectagram: Makefile changed, Port require always DATA
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-18 02:10 UTC by nemysis
Modified: 2012-08-20 17:30 UTC (History)
1 user (show)

See Also:


Attachments
connectagram-1.0.1.patch (793 bytes, patch)
2012-08-18 02:10 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-08-18 02:10:07 UTC
Makefile changed:

Deleted why Port require always DATA

-OPTIONS_DEFINE= DATA
-OPTIONS_DEFAULT= DATA


Not install this file, why isn't needed for installed Port

INSTALL


Changed all to ${PORTNAME}

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2012-08-18 06:49:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-08-20 17:24:07 UTC
Author: jgh
Date: Mon Aug 20 16:23:55 2012
New Revision: 302821
URL: http://svn.freebsd.org/changeset/ports/302821

Log:
  - data is required
  - use portname variable in plist
  
  PR:	170724
  Submitted by:	maintainer, nemysis@gmx.ch

Modified:
  head/games/connectagram/Makefile

Modified: head/games/connectagram/Makefile
==============================================================================
--- head/games/connectagram/Makefile	Mon Aug 20 16:10:57 2012	(r302820)
+++ head/games/connectagram/Makefile	Mon Aug 20 16:23:55 2012	(r302821)
@@ -7,6 +7,7 @@
 
 PORTNAME=	connectagram
 PORTVERSION=	1.0.1
+PORTREVISION=	1
 CATEGORIES=	games
 MASTER_SITES=	http://gottcode.org/${PORTNAME}/
 DISTNAME=	${PORTNAME}-${DISTVERSION}-src
@@ -16,9 +17,6 @@ COMMENT=	Word unscrambling game
 
 LICENSE=	GPLv3
 
-OPTIONS_DEFINE=	DATA
-OPTIONS_DEFAULT=	DATA
-
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
 
 USE_BZIP2=	yes
@@ -29,11 +27,11 @@ INSTALLS_ICONS=	yes
 MAKE_JOBS_SAFE=	yes
 
 PORTDATA=	*
-PORTDOCS=	ChangeLog INSTALL
+PORTDOCS=	ChangeLog
 
-PLIST_FILES=	bin/connectagram \
-	share/applications/connectagram.desktop \
-	share/icons/hicolor/48x48/apps/connectagram.png
+PLIST_FILES=	bin/${PORTNAME} \
+	share/applications/${PORTNAME}.desktop \
+	share/icons/hicolor/48x48/apps/${PORTNAME}.png
 
 PLIST_DIRSTRY=	share/icons/hicolor/48x48/apps \
 	share/icons/hicolor/48x48 \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2012-08-20 17:24:13 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!