Bug 170777 - [PATCH] Not LIBS but LDFLAGS in Makefile of lang/ruby19
Summary: [PATCH] Not LIBS but LDFLAGS in Makefile of lang/ruby19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ruby (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-20 06:40 UTC by ksmakoto
Modified: 2013-06-06 16:23 UTC (History)
0 users

See Also:

Attachments
file.diff (333 bytes, patch)
2012-08-20 06:40 UTC, ksmakoto 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ksmakoto 2012-08-20 06:40:08 UTC 
THis should use variable LDFLAGS, not LIBS. (some utility (example mkrf) cause trouble)

--- Makefile.ORG	2012-08-20 14:30:45.000000000 +0900
+++ Makefile	2012-08-07 16:44:05.000000000 +0900
@@ -77,7 +77,7 @@
 .endif
 
 CONFIGURE_ENV=	CFLAGS="-I${LOCALBASE}/include ${CFLAGS}" \
-		LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}" \
+		LIBS="-L${LOCALBASE}/lib ${LDFLAGS}" \
 		debugflags=
 
 .if ${RUBY_VER} == ${RUBY_DEFAULT_VER}

Fix: see patch

Patch attached with submission follows:
How-To-Repeat: ---
Comment 1 ksmakoto 2012-08-20 06:54:52 UTC 
Hello,

sorry, patch is reversed. please reverse to read.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-09-04 17:26:36 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ruby

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 3 Steve Wills freebsd_committer freebsd_triage 2013-05-27 18:22:49 UTC 
Hi,

I tried this, but it just causes a build problem for me:

linking shared-library libruby19.so.19
/usr/bin/ld: cannot find -lexecinfo
*** Error code 1

Can you tell me more about what problem you were having?

Steve
Comment 4 ksmakoto 2013-06-03 12:25:10 UTC 
Hello,

On Mon, 27 May 2013 13:22:49 -0400
"Steve Wills" <swills@FreeBSD.org> wrote:
> Hi,
> 
> I tried this, but it just causes a build problem for me:
> 
> linking shared-library libruby19.so.19
> /usr/bin/ld: cannot find -lexecinfo
> *** Error code 1
> 
> Can you tell me more about what problem you were having?
> 
> Steve

It looks to need some more modify, but I missed it.
Sorry, please reject this PR.
Comment 5 Bryan Drewery freebsd_committer freebsd_triage 2013-06-06 16:23:35 UTC 
State Changed
From-To: open->closed

Per submitter request