Bug 170811 - [PATCH]: fix ports option for multiple ports without maintainers
Summary: [PATCH]: fix ports option for multiple ports without maintainers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 00:00 UTC by Artis Caune
Modified: 2012-08-24 03:40 UTC (History)
0 users

See Also:


Attachments
file.diff (2.23 KB, patch)
2012-08-21 00:00 UTC, Artis Caune
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Artis Caune 2012-08-21 00:00:25 UTC
There are typos in Makefile for the following ports:
    games/evq3
    games/abe
    audio/jokosher
    deskutils/kdepim3
    print/pnm2ppa

patch is agains /usr/ports directory!

Fix: Patch attached with submission follows:
Comment 1 Raphael Kubo da Costa freebsd_committer 2012-08-24 03:33:23 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rakuco

I'll take it.
Comment 2 Raphael Kubo da Costa freebsd_committer 2012-08-24 03:36:23 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer 2012-08-24 03:36:32 UTC
Author: rakuco
Date: Fri Aug 24 02:36:17 2012
New Revision: 303051
URL: http://svn.freebsd.org/changeset/ports/303051

Log:
  Fix some OptionsNG conversion typos.
  
  PR:		ports/170811
  Submitted by:	Artis Caune <Artis.Caune@gmail.com>

Modified:
  head/audio/jokosher/Makefile
  head/deskutils/kdepim3/Makefile
  head/games/abe/Makefile
  head/games/evq3/Makefile
  head/print/pnm2ppa/Makefile

Modified: head/audio/jokosher/Makefile
==============================================================================
--- head/audio/jokosher/Makefile	Fri Aug 24 02:29:12 2012	(r303050)
+++ head/audio/jokosher/Makefile	Fri Aug 24 02:36:17 2012	(r303051)
@@ -60,7 +60,7 @@ PLIST_SUB+=	OMF="@comment "
 .endif
 
 .for plugin in flac gconf jack ladspa lame mp3 pulse vorbis
-. if ${PORT_OPTIONS:M${plugin:U})
+. if ${PORT_OPTIONS:M${plugin:U}}
 USE_GSTREAMER+=${plugin}
 . endif
 .endfor

Modified: head/deskutils/kdepim3/Makefile
==============================================================================
--- head/deskutils/kdepim3/Makefile	Fri Aug 24 02:29:12 2012	(r303050)
+++ head/deskutils/kdepim3/Makefile	Fri Aug 24 02:36:17 2012	(r303051)
@@ -59,7 +59,7 @@ PORT_OPTIONS+=	GNOKII
 .	endif
 .endif
 
-.if ${PORT_OPTIONS:MGNOKII)
+.if ${PORT_OPTIONS:MGNOKII}
 LIB_DEPENDS+=	gnokii:${PORTSDIR}/comms/gnokii
 .endif
 

Modified: head/games/abe/Makefile
==============================================================================
--- head/games/abe/Makefile	Fri Aug 24 02:29:12 2012	(r303050)
+++ head/games/abe/Makefile	Fri Aug 24 02:36:17 2012	(r303051)
@@ -37,13 +37,13 @@ post-install:
 
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MGOD_MODE} || !empty{PORT_OPTIONS:MOPTIMIZED_CFLAGS}
+.if ${PORT_OPTIONS:MGOD_MODE} || !empty(PORT_OPTIONS:MOPTIMIZED_CFLAGS)
 post-patch:
 .   if ${PORT_OPTIONS:MGOD_MODE}
 	@${REINPLACE_CMD} -e 's|\(#define GOD_MODE\) 0|\1 1|' \
 		${WRKSRC}/src/Game.h
 .   endif
-.   if empty(PORT_OPTIONS:MOPTIMIZED_CFLAGS}
+.   if empty(PORT_OPTIONS:MOPTIMIZED_CFLAGS)
 	@${REINPLACE_CMD} -e 's|-O2||g ; \
 		s|-fomit-frame-pointer||g ; \
 		s|-ffast-math||g ; \

Modified: head/games/evq3/Makefile
==============================================================================
--- head/games/evq3/Makefile	Fri Aug 24 02:29:12 2012	(r303050)
+++ head/games/evq3/Makefile	Fri Aug 24 02:36:17 2012	(r303051)
@@ -66,7 +66,7 @@ MAKE_ENV+=	HAVE_VM_COMPILED=true
 .   if ${PORT_OPTIONS:MCURL}
 LIB_DEPENDS+=	curl.6:${PORTSDIR}/ftp/curl
 MAKE_ENV+=	USE_CURL=1
-.       if ${PORT_OPTIONS:MCURL_DLOPEN)
+.       if ${PORT_OPTIONS:MCURL_DLOPEN}
 MAKE_ENV+=	USE_CURL_DLOPEN=1
 .       endif
 .   endif
@@ -74,7 +74,7 @@ MAKE_ENV+=	USE_CURL_DLOPEN=1
 .   if ${PORT_OPTIONS:MOPENAL}
 USE_OPENAL=	al
 MAKE_ENV+=	USE_OPENAL=1
-.       if ${PORT_OPTIONS:MOPENAL_DLOPEN)
+.       if ${PORT_OPTIONS:MOPENAL_DLOPEN}
 MAKE_ENV+=	USE_OPENAL_DLOPEN=1
 .       endif
 .   endif

Modified: head/print/pnm2ppa/Makefile
==============================================================================
--- head/print/pnm2ppa/Makefile	Fri Aug 24 02:29:12 2012	(r303050)
+++ head/print/pnm2ppa/Makefile	Fri Aug 24 02:36:17 2012	(r303051)
@@ -29,7 +29,7 @@ PKGDEINSTALL=	${PKGINSTALL}
 
 .include <bsd.port.pre.mk>
 
-.if defined(A4) || !empty(PORT_OPTIONS:MA4SIZE}
+.if defined(A4) || !empty(PORT_OPTIONS:MA4SIZE)
 RUN_DEPENDS=	enscript:${PORTSDIR}/print/enscript-a4
 .else
 RUN_DEPENDS=	enscript:${PORTSDIR}/print/enscript-letter
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"