Mk/bsd.ruby.mk says RUBY variable can be set by a port. But when I set it for my own port, make shows some errors and some RUBY_* variables such as RUBY_VERSION are not properly set. How-To-Repeat: Install lang/ruby19. In any rubygem port directory, for example, in textproc/rubygem-htmlentities: # make RUBY=/usr/local/bin/ruby19 -e:1: Use RbConfig instead of obsolete and deprecated Config. -e:2:in `<main>': uninitialized constant VERSION (NameError) "/usr/ports/Mk/bsd.ruby.mk", line 151: warning: "/usr/local/bin/ruby19 -r rbconfig -e 'C = Config::CONFIG' -e 'puts VERSION'" returned non-zero status -e:1: Use RbConfig instead of obsolete and deprecated Config. -e:1: Use RbConfig instead of obsolete and deprecated Config. -e:1: Use RbConfig instead of obsolete and deprecated Config. -e:1: Use RbConfig instead of obsolete and deprecated Config. -e:1: Use RbConfig instead of obsolete and deprecated Config.
Responsible Changed From-To: freebsd-ports-bugs->ruby bsd.ruby.mk is ruby territory (via the GNATS Auto Assign Tool)
Responsible Changed From-To: ruby->swills I'll take it.
Hi, Sorry for the super late reply on this, but it does seem to still be an issue. If you are still interested, I've attached a proposed patch. Let me know if this solves it for you. Thanks, Steve
Hi, > Sorry for the super late reply on this, but it does seem to still be an issue. > If you are still interested, I've attached a proposed patch. Let me know if > this solves it for you. Thanks a lot. Your patch works well for me. Regards. -- Hiroto Kagotani <hiroto.kagotani@gmail.com>
Author: swills Date: Sun Apr 13 02:44:45 2014 New Revision: 351179 URL: http://svnweb.freebsd.org/changeset/ports/351179 QAT: https://qat.redports.org/buildarchive/r351179/ Log: - Fix issues with specifying ${RUBY} variable PR: ports/170916 Reported by: Hiroto Kagotani <hiroto.kagotani@gmail.com> Modified: head/Mk/bsd.ruby.mk Modified: head/Mk/bsd.ruby.mk ============================================================================== --- head/Mk/bsd.ruby.mk Sun Apr 13 02:41:30 2014 (r351178) +++ head/Mk/bsd.ruby.mk Sun Apr 13 02:44:45 2014 (r351179) @@ -152,14 +152,14 @@ RUBY_VER?= ${RUBY_DEFAULT_VER} IGNORE= cannot install: you set the variable RUBY to "${RUBY}", but it does not seem to exist. Please specify an already installed ruby executable. .endif -_RUBY_TEST!= ${RUBY} -e 'begin; require "rbconfig"; rescue LoadError; puts "error"; end' -.if !empty(_RUBY_TEST) +_RUBY_TEST!= ${RUBY} -e 'begin; require "rbconfig"; puts "ok" ; rescue LoadError; puts "error"; end' +.if !empty(_RUBY_TEST) && ${_RUBY_TEST} != "ok" IGNORE= cannot install: you set the variable RUBY to "${RUBY}", but it failed to include rbconfig. Please specify a properly installed ruby executable. .endif -_RUBY_CONFIG= ${RUBY} -r rbconfig -e 'C = Config::CONFIG' -e +_RUBY_CONFIG= ${RUBY} -r rbconfig -e 'C = RbConfig::CONFIG' -e -RUBY_VERSION!= ${_RUBY_CONFIG} 'puts VERSION' +RUBY_VERSION!= ${_RUBY_CONFIG} 'puts C["ruby_version"]' RUBY_SUFFIX?= # empty RUBY_ARCH!= ${_RUBY_CONFIG} 'puts C["target"]' _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Patch committed! Thanks!