Bug 171157 - misc/mc: invisible command line after inserting from history
Summary: misc/mc: invisible command line after inserting from history
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Khon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-29 10:20 UTC by Alexey Markov
Modified: 2012-08-29 16:50 UTC (History)
0 users

See Also:


Attachments
patch.txt (362 bytes, text/plain; format=flowed)
2012-08-29 14:21 UTC, Alexey Markov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Markov 2012-08-29 10:20:01 UTC
After updating misc/mc port to the latest version 4.8.1.4 inserting commands from history a slightly broken: all command from history inserted to command line as invisible, but after deleting one char or moving cursor all chars became visible again.

How-To-Repeat: 1. Update misc/mc to version 4.8.1.4
2. Start Midnight Commander
3. Try to load a command from a history: Esc+h, Enter
4. See an empty spaces in the command line
5. Move a cursor by hitting Ctrl+b
6. All chars in the command line are visible again
Comment 1 Edwin Groothuis freebsd_committer 2012-08-29 10:20:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->fjoe

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Max Khon freebsd_committer 2012-08-29 11:01:02 UTC
State Changed
From-To: open->feedback

Please report this upstream to the midnight commander issue tracker.
Comment 3 Alexey Markov 2012-08-29 13:54:51 UTC
Done.

https://www.midnight-commander.org/ticket/2870

-- 
WBR, Alexey Markov.
Comment 4 Alexey Markov 2012-08-29 14:08:13 UTC
It seems this bug already fixed in the current version of MC:

https://www.midnight-commander.org/ticket/2810

Still needs to update a port misc/mc to the version 4.8.4.

-- 
WBR, Alexey Markov.
Comment 5 Alexey Markov 2012-08-29 14:21:17 UTC
This one-line patch solves the problem. I think it worth to
add it to the port.

-- 
WBR, Alexey Markov.
Comment 6 dfilter service freebsd_committer 2012-08-29 14:46:42 UTC
Author: fjoe
Date: Wed Aug 29 13:46:28 2012
New Revision: 303340
URL: http://svn.freebsd.org/changeset/ports/303340

Log:
  Fix bug: alt+h command input line not updated
  
  The fix is obtained from the upstream:
  https://www.midnight-commander.org/ticket/2810
  
  PR:		171157

Added:
  head/misc/mc/files/patch-lib-widget-input.c   (contents, props changed)
Modified:
  head/misc/mc/Makefile

Modified: head/misc/mc/Makefile
==============================================================================
--- head/misc/mc/Makefile	Wed Aug 29 13:29:16 2012	(r303339)
+++ head/misc/mc/Makefile	Wed Aug 29 13:46:28 2012	(r303340)
@@ -7,6 +7,7 @@
 
 PORTNAME=	mc
 PORTVERSION=	4.8.1.4
+PORTREVISION=	1
 CATEGORIES=	misc shells
 MASTER_SITES=	http://www.midnight-commander.org/downloads/ \
 		${MASTER_SITE_SUNSITE}

Added: head/misc/mc/files/patch-lib-widget-input.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/misc/mc/files/patch-lib-widget-input.c	Wed Aug 29 13:46:28 2012	(r303340)
@@ -0,0 +1,10 @@
+--- lib/widget/input.c.orig	2012-08-29 20:27:24.000000000 +0700
++++ lib/widget/input.c	2012-08-29 20:27:53.000000000 +0700
+@@ -1179,6 +1179,7 @@
+     in->mark = 0;
+     in->need_push = TRUE;
+     in->charpoint = 0;
++    input_update (in, TRUE);
+ }
+ 
+ /* --------------------------------------------------------------------------------------------- */
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Max Khon freebsd_committer 2012-08-29 14:46:54 UTC
State Changed
From-To: feedback->closed

The fix from the upstream (https://www.midnight-commander.org/ticket/2810) 
was committed (try mc 4.8.1.4_1).