Bug 171473 - [PATCH] multimedia/handbrake doesn't load dvdcss library
Summary: [PATCH] multimedia/handbrake doesn't load dvdcss library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Damjan Marion
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-08 21:10 UTC by heathn
Modified: 2013-06-17 10:30 UTC (History)
0 users

See Also:


Attachments
file.diff (399 bytes, patch)
2012-09-08 21:10 UTC, heathn
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description heathn 2012-09-08 21:10:09 UTC
Handbrake tries to dlopen libdvdcss.so.2.  The library the libdvdcss pacakge installs is actually libdvdcss.so.3 so the call always fails and handbrake fails to properly read CSS-encoded DVDs.

Fix: dlopen the correct library.  Patch is attached.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/multimedia/handbrake; make install

Try to encode a CSS-encoded DVD.  Garbled output is the result.
Comment 1 Edwin Groothuis freebsd_committer 2012-09-08 21:10:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dmarion

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2013-06-17 10:24:05 UTC
Author: danfe
Date: Mon Jun 17 09:23:52 2013
New Revision: 321090
URL: http://svnweb.freebsd.org/changeset/ports/321090

Log:
  Handbrake tries to dlopen() libdvdcss.so.2, while library installed by the
  libdvdcss package is actually libdvdcss.so.3, so the call always fails and
  handbrake is unable to properly read CSS-encoded DVDs.
  
  Patch in the PR suggested bumping requested shlib version accordingly, but
  methinks it is better to just remove it completely from CSS_LIB definition.
  While here, register run-time dependency on `multimedia/libdvdcss'.
  
  PR:		ports/171473
  Submitted by:	Heath Nielson
  Approved by:	maintainer timeout (dmarion, over 9 months)

Modified:
  head/multimedia/handbrake/Makefile

Modified: head/multimedia/handbrake/Makefile
==============================================================================
--- head/multimedia/handbrake/Makefile	Mon Jun 17 08:39:52 2013	(r321089)
+++ head/multimedia/handbrake/Makefile	Mon Jun 17 09:23:52 2013	(r321090)
@@ -3,7 +3,7 @@
 
 PORTNAME=	handbrake
 PORTVERSION=	0.9.8
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	multimedia
 MASTER_SITES=	SF/${PORTNAME}/${PORTVERSION} \
 		http://download.handbrake.fr/handbrake/contrib/:contrib
@@ -38,6 +38,7 @@ LICENSE=	GPLv2
 
 BUILD_DEPENDS=	yasm:${PORTSDIR}/devel/yasm
 LIB_DEPENDS=	fribidi:${PORTSDIR}/converters/fribidi
+RUN_DEPENDS=	${LOCALBASE}/lib/libdvdcss.so:${PORTSDIR}/multimedia/libdvdcss
 
 USE_AUTOTOOLS=	libtool aclocal
 LIBTOOLFILES=	configure
@@ -125,6 +126,8 @@ post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|' \
 		${WRKSRC}/contrib/libass/module.defs \
 		${WRKSRC}/libhb/module.defs ${WRKSRC}/test/module.defs
+	@${REINPLACE_CMD} -e 's|libdvdcss\.so\.2|libdvdcss.so|' \
+		${BUILD_WRKSRC}/contrib/libdvdread/libdvdread/src/dvd_input.c
 
 do-install:
 	${INSTALL_PROGRAM} ${BUILD_WRKSRC}/HandBrakeCLI ${PREFIX}/bin
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Alexey Dokuchaev freebsd_committer 2013-06-17 10:25:40 UTC
State Changed
From-To: open->closed

Slightly different version committed (r321090), thanks!