Bug 171567 - [PATCH] japanese/font-ricty: rendered as non-monospace font
Summary: [PATCH] japanese/font-ricty: rendered as non-monospace font
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 09:30 UTC by hiroto.kagotani
Modified: 2012-09-13 19:20 UTC (History)
1 user (show)

See Also:


Attachments
ja-font-ricty-3.2.0_2.patch (3.27 KB, patch)
2012-09-12 09:30 UTC, hiroto.kagotani
no flags Details | Diff
font-ricty.patch (1.35 KB, patch)
2012-09-13 13:58 UTC, Masaki TAGAWA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hiroto.kagotani 2012-09-12 09:30:02 UTC
Though Ricty is expected to be a monospace font for programming, it
is treated as non-monospace font due to its incompatibility with
FreeBSD's renderer.

Added file(s):
- files/patch-ricty_generator.sh

Port maintainer (masaki@club.kyutech.ac.jp) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: suffix)

Fix: Replace the generator script with the latest one in the head of
the upstream repository.
(Only three lines are significant)
How-To-Repeat: On emacs, set font by (set-frame-font "Ricty-12.5"),
and type 40 l's, 40 i's and 40 D's on consequtive lines for example.
Comment 1 Edwin Groothuis freebsd_committer 2012-09-12 09:30:15 UTC
Maintainer of japanese/font-ricty,

Please note that PR ports/171567 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/171567

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2012-09-12 09:30:21 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Masaki TAGAWA 2012-09-12 13:15:49 UTC
Kagotani-san:

Thank you for your PR.

I checked your problem report.
I agree on your patch, but please let me ask a question.
# This is a trifling matter.

1.
Why did you make it as ricty_version="3.2.1b"?
I think "3.2.0p1" is better, is this ok?

2.
If you already contacted the upstream author, let me know.


Thanks,
Masaki
Comment 4 hiroto.kagotani 2012-09-12 15:49:02 UTC
Hi,

> 1.
> Why did you make it as ricty_version="3.2.1b"?
> I think "3.2.0p1" is better, is this ok?

This sample fix was generated by just diff'ing
https://raw.github.com/yascentur/Ricty/3.2.0/ricty_generator.sh
and
https://raw.github.com/yascentur/Ricty/master/ricty_generator.sh

> 2.
> If you already contacted the upstream author, let me know.

Yes, I reported the problem to the author 1 month ago, and he fixed it.

-- 
Hiroto Kagotani
<hiroto.kagotani@gmail.com>
Comment 5 Masaki TAGAWA 2012-09-13 13:58:22 UTC
Hi Kagotani-san,

>  > 1.
>  > Why did you make it as ricty_version="3.2.1b"?
>  > I think "3.2.0p1" is better, is this ok?
>
>  This sample fix was generated by just diff'ing
>  https://raw.github.com/yascentur/Ricty/3.2.0/ricty_generator.sh
>  and
>  https://raw.github.com/yascentur/Ricty/master/ricty_generator.sh
>
>  > 2.
>  > If you already contacted the upstream author, let me know.
>
>  Yes, I reported the problem to the author 1 month ago, and he fixed it.

Ok, I see.
I attached my patch for this PR.
I believe this will be more better because this make its PORTVERSION changed.
Users of japanese/font-ricty can notice this update.

If you think this patch is Ok, let me know, and a committer will take
care of it.


Thanks,
Masaki


-- Masaki TAGAWA
Comment 6 hiroto.kagotani 2012-09-13 14:45:33 UTC
Hi,

It works very well and is much better than mine!
Thank you very much.

-- 
Hiroto Kagotani
<hiroto.kagotani@gmail.com>
Comment 7 Ruslan Makhmatkhanov freebsd_committer 2012-09-13 19:08:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rm

I will take it.
Comment 8 dfilter service freebsd_committer 2012-09-13 19:16:19 UTC
Author: rm
Date: Thu Sep 13 18:16:05 2012
New Revision: 304227
URL: http://svn.freebsd.org/changeset/ports/304227

Log:
  - update to 3.2.1b that fix rendering of this font on FreeBSD
  
  while here:
  - align dependencies list (trim unneeded tabs)
  - switch to USE_GITHUB
  - tab -> space in pkg-descr:WWW
  
  PR:		171567
  Submitted by:	Masaki TAGAWA <masaki at club.kyutech.ac dot jp> (maintainer, final patch revision)
  Reported by:	Hiroto Kagotani <hiroto.kagotani at gmail dot com> (original patch)

Modified:
  head/japanese/font-ricty/Makefile
  head/japanese/font-ricty/distinfo
  head/japanese/font-ricty/pkg-descr

Modified: head/japanese/font-ricty/Makefile
==============================================================================
--- head/japanese/font-ricty/Makefile	Thu Sep 13 18:07:55 2012	(r304226)
+++ head/japanese/font-ricty/Makefile	Thu Sep 13 18:16:05 2012	(r304227)
@@ -6,10 +6,8 @@
 #
 
 PORTNAME=	ricty
-PORTVERSION=	3.2.0
-PORTREVISION=	2
+PORTVERSION=	3.2.1b
 CATEGORIES=	japanese x11-fonts
-MASTER_SITES=	https://nodeload.github.com/yascentur/Ricty/tarball/${PORTVERSION}?dummy=/
 PKGNAMEPREFIX=	ja-font-
 
 MAINTAINER=	masaki@club.kyutech.ac.jp
@@ -17,12 +15,17 @@ COMMENT=	Ricty - fonts for programming
 
 RUN_DEPENDS=	fc-cache:${PORTSDIR}/x11-fonts/fontconfig
 BUILD_DEPENDS=	${LOCALBASE}/${X_FONTSDIR}/OTF/Inconsolata.otf:${PORTSDIR}/x11-fonts/inconsolata-ttf \
-				${LOCALBASE}/${X_FONTSDIR}/TTF/migu-1m-regular.ttf:${PORTSDIR}/japanese/font-migu \
-				${LOCALBASE}/${X_FONTSDIR}/TTF/migu-1m-bold.ttf:${PORTSDIR}/japanese/font-migu \
-				fontforge:${PORTSDIR}/print/fontforge
+		${LOCALBASE}/${X_FONTSDIR}/TTF/migu-1m-regular.ttf:${PORTSDIR}/japanese/font-migu \
+		${LOCALBASE}/${X_FONTSDIR}/TTF/migu-1m-bold.ttf:${PORTSDIR}/japanese/font-migu \
+		fontforge:${PORTSDIR}/print/fontforge
+
+USE_GITHUB=	yes
+GH_ACCOUNT=	yascentur
+GH_COMMIT=	${GH_TAGNAME}
+GH_PROJECT=	Ricty
+GH_TAGNAME=	dfd3637
 
 NO_PACKAGE=	redistribution is not allowed
-FETCH_BEFORE_ARGS=	-o ${DISTNAME}${EXTRACT_SUFX}
 PKGINSTALL=	${WRKDIR}/pkg-install
 PKGDEINSTALL=	${WRKDIR}/pkg-install
 SUB_FILES=	pkg-install
@@ -30,8 +33,6 @@ SUB_LIST=	X_FONTSDIR=${PREFIX}/${X_FONTS
 PLIST_SUB=	X_FONTSDIR=${X_FONTSDIR} \
 		LOCAL_FONTSDIR=${LOCAL_FONTSDIR}
 PORTDOCS=	README.md
-TAG=	b9d8b9c
-WRKSRC=	${WRKDIR}/yascentur-Ricty-${TAG}
 
 LOCAL_FONTSDIR=	share/fonts
 X_FONTSDIR=	lib/X11/fonts

Modified: head/japanese/font-ricty/distinfo
==============================================================================
--- head/japanese/font-ricty/distinfo	Thu Sep 13 18:07:55 2012	(r304226)
+++ head/japanese/font-ricty/distinfo	Thu Sep 13 18:16:05 2012	(r304227)
@@ -1,2 +1,2 @@
-SHA256 (ricty-3.2.0.tar.gz) = bb2bf6d7762b5e6e13d237bd82ba43d6faffc17b7e6d541db89d58a73a8a319e
-SIZE (ricty-3.2.0.tar.gz) = 13286
+SHA256 (ricty-3.2.1b.tar.gz) = b31ba25e53af2f2aff2030e96521c31b2a59f5c9ae1387a8875767bb3d4eef0a
+SIZE (ricty-3.2.1b.tar.gz) = 13763

Modified: head/japanese/font-ricty/pkg-descr
==============================================================================
--- head/japanese/font-ricty/pkg-descr	Thu Sep 13 18:07:55 2012	(r304226)
+++ head/japanese/font-ricty/pkg-descr	Thu Sep 13 18:16:05 2012	(r304227)
@@ -1,4 +1,4 @@
 Ricty is a Japanese TrueType font, consisting of
 Inconsolata and Migu 1M.
 
-WWW:	http://save.sys.t.u-tokyo.ac.jp/~yusa/fonts/ricty.html
+WWW: http://save.sys.t.u-tokyo.ac.jp/~yusa/fonts/ricty.html
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 9 Ruslan Makhmatkhanov freebsd_committer 2012-09-13 19:18:00 UTC
State Changed
From-To: feedback->closed

Committed, thank you!