Bug 171761 - [zfs] [patch] Small patch to (temporarily) remove -r from zfs send usage and zfs(8)
Summary: [zfs] [patch] Small patch to (temporarily) remove -r from zfs send usage and ...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 9.1-PRERELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-19 01:30 UTC by Thomas Steen Rasmussen / Tykling
Modified: 2012-10-16 21:01 UTC (History)
0 users

See Also:


Attachments
file.diff (1.59 KB, patch)
2012-09-19 01:30 UTC, Thomas Steen Rasmussen / Tykling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Steen Rasmussen / Tykling 2012-09-19 01:30:10 UTC
This thread describes the problem and proposed long-term solution: http://lists.freebsd.org/pipermail/freebsd-fs/2012-September/015052.html

Basically FreeBSD and IllumOS are both missing code to handle the -r switch to zfs send. 

mm@ opened an issue at https://www.illumos.org/issues/3144 which has been closed as a duplicate of https://www.illumos.org/issues/2811 so upstream is working on it.

While we are waiting for a long-term solution from upstream I propose a short-term solution by suggesting that we remove -r from the usage output of "zfs send" and from the zfs(8) manpage.

Fix: 1: Apply this patch so we no longer advertise non-existing features
2: Wait until IllumOS upstream fixes problem
3. Import upstream fix when it is ready

Patch attached with submission follows:
How-To-Repeat: try using zfs send -r, see that the option is unsupported. Also, see that the option is documented in usage and manpage.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2012-10-15 00:32:41 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 2 Martin Matuska freebsd_committer freebsd_triage 2012-10-16 20:51:30 UTC
This has already been fixed in r240955 and will be committed to 9-STABLE
together with feature flags after 9.1-RELEASE is out.
http://svn.freebsd.org/changeset/base/240955

-- 
Martin Matuska
FreeBSD committer
http://blog.vx.sk
Comment 3 Martin Matuska freebsd_committer freebsd_triage 2012-10-16 21:01:03 UTC
Responsible Changed
From-To: freebsd-fs->mm

I'll take it.
Comment 4 Martin Matuska freebsd_committer freebsd_triage 2012-10-16 21:01:11 UTC
State Changed
From-To: open->closed

Resolved. Thanks!